GeSHi claims to support GESHI_NORMAL_LINE_NUMBERS but doesn't
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jun 6 2015, 11:48 AM

Description

The documentation (https://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi) claims that the line attribute can be empty (default=fancy) or explicitly set to fancy or default. Fancy means every nth line number (default n=5) is bolded.

Firstly this is a lie, the code only detects the presence of 'line' and sets fancy mode regardless of the value.

Secondly there is no way to customise the value of n.

Details

	Subject	Repo	Branch	Lines +/-
	Use normal line numbers	mediawiki/extensions/SyntaxHighlight_GeSHi	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T103964: Follow-up from migration GeSHi→Pygments: Attribute and HTML issues
rESHG28ff155a6c23: Use normal line numbers
rMEXT9b51847eb6a2: Updated mediawiki/extensions Project…

Event Timeline

Esanders created this task.Jun 6 2015, 11:48 AM

Esanders raised the priority of this task from to Needs Triage.

Esanders updated the task description. (Show Details)

Esanders added a project: SyntaxHighlight.

Esanders subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2015, 11:48 AM

Personally I think highlighting every nth line number is a fairly useless feature, and we simplify things by making line a boolean attribute that enables normal line numbering.

Jdforrester-WMF triaged this task as Low priority.Jun 9 2015, 12:26 AM

Jdforrester-WMF set Security to None.

Change 216983 had a related patch set uploaded (by Esanders):
Use normal line numbers

https://gerrit.wikimedia.org/r/216983

gerritbot added a project: Patch-For-Review.Jun 9 2015, 3:06 PM

Change 216983 merged by jenkins-bot:
Use normal line numbers

https://gerrit.wikimedia.org/r/216983

Esanders mentioned this in rMEXT9b51847eb6a2: Updated mediawiki/extensions Project….Jun 10 2015, 4:06 AM

Esanders mentioned this in rESHG28ff155a6c23: Use normal line numbers.