Add an API action to just change content model
Closed, ResolvedPublic
Actions

Description

action=changecontentmodel to accompany the new Special:ChangeContentModel (rMWfa31bf1675af: Add Special:ChangeContentModel). We already allow people to change content model via action=edit, this would let them do it without re-sending the page text.

Details

	Subject	Repo	Branch	Lines +/-
	Add a ContentModelChange helper, and an api module that uses it	mediawiki/core	master	+1 K -99

Customize query in gerrit

Related Objects

Mentioned In: T270988: CVE-2021-30155: Titleblacklist didn't prevent creation of pages by Special:ChangeContentModel when a rule was met
T253080: Add new ContentModelChangeFactory interface, implement with PageCommandFactory
Mentioned Here: rMWfa31bf1675af: Add Special:ChangeContentModel

Event Timeline

Legoktm created this task.Jul 28 2015, 5:53 PM

Legoktm raised the priority of this task from to Medium.

Legoktm updated the task description. (Show Details)

Legoktm added projects: MediaWiki-Action-API, MediaWiki-ContentHandler.

Legoktm added subscribers: Legoktm, Anomie.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2015, 5:53 PM

Anomie moved this task from Unsorted to Needs Code on the MediaWiki-Action-API board.Jul 28 2015, 6:01 PM

DannyS712 claimed this task.Aug 29 2019, 8:31 AM

DannyS712 lowered the priority of this task from Medium to Low.

Restricted Application added projects: User-DannyS712, Platform Engineering. · View Herald TranscriptAug 29 2019, 8:31 AM

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Aug 29 2019, 8:31 AM

daniel moved this task from Inbox to Feature Requests to Review on the Platform Engineering board.Aug 29 2019, 10:11 AM

Is Platform Engineering okay with this addition?

Seems reasonable and uncontroversial to me, I'd review and merge a patch without asking for additional consensus. I don't know what the actual PMs might think.

In T107174#5740187, @Anomie wrote:

Seems reasonable and uncontroversial to me, I'd review and merge a patch without asking for additional consensus. I don't know what the actual PMs might think.

Thanks. I've written most of it, just trying to expand the tests to bit more (currently at 84% coverage)

Change 563701 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add an api module to edit the content model of a page

https://gerrit.wikimedia.org/r/563701

gerritbot added a project: Patch-For-Review.Jan 11 2020, 11:49 PM

DannyS712 moved this task from Needs Code to Needs Review on the MediaWiki-Action-API board.Jan 11 2020, 11:54 PM

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.

Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jan 13 2020, 6:28 PM

Anomie moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.

Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Feb 11 2020, 3:49 PM

@Anomie I've eliminated the duplication and added lots of tests. Can you take another look?

WDoranWMF moved this task from External Code Review In Progress to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Mar 3 2020, 8:35 PM

Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Mar 11 2020, 7:24 PM

Anomie moved this task from External Code Review In Progress to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Mar 11 2020, 8:09 PM

Change 563701 merged by jenkins-bot:
[mediawiki/core@master] Add a ContentModelChange helper, and an api module that uses it