replace.py does not recognize replacements in user-fixes.py
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Beta16
	Sep 10 2015, 2:40 PM

Description

Last time I've used replace.py was in march 2015 and all work correctly.
Now when I run this script I can't use replacements in user-fixes.py file.

The command is:

python pwb.py replace.py "-file:lista.txt" "-always" "-fix:carattericontrollo" "-summary:test"

That returns:

Available predefined fixes are: correct-ar, isbn, HTML, case-de, datum, syntax, grammar-de, syntax-safe, specialpages, fckeditor, vonbis, music, yu-tld

these are contained in the file fixes.py. The replacements contained in user-fixes.py are not listed.

My PyWikiBot version is:

Pywikibot: [https] r-pywikibot-core.git (47d2b86, g6404, 2015/09/10, 22:25:12, ok)
Release version: 2.0b3
requests version: 2.2.1
  cacerts: /etc/ssl/certs/ca-certificates.crt
    certificate test: ok
Python: 2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2]
PYWIKIBOT2_DIR: Not set
PYWIKIBOT2_DIR_PWB:
PYWIKIBOT2_NO_USER_CONFIG: Not set
Config base dir: /data/project/betabot/core

Details

	Subject	Repo	Branch	Lines +/-
	[FIX] fixes: Allow replacing the variable	pywikibot/core	master	+62 -1

Customize query in gerrit

Related Objects

Mentioned In: rPWBCde5248a93ec6: [FIX] fixes: Allow replacing the variable
Mentioned Here: rPWBC3ac18802118f: [FIX] replace: Add replacements to their container

Event Timeline

Beta16 created this task.Sep 10 2015, 2:40 PM

Beta16 raised the priority of this task from to Needs Triage.

Beta16 updated the task description. (Show Details)

Beta16 added a project: Pywikibot-replace.py.

Beta16 subscribed.

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptSep 10 2015, 2:40 PM

Does it the list of fixes say:

The user fixes file could not be found: …

You're probably looking for argument -replacementfile instead of -file.
I also noticed that despite -file not being listed in the possible switches, there is an erroneous example using it.

-file is defining a list of pages to work on. The user fixes file should be implicitly loaded without a parameter.

Sorry, I misread the issue and also -file exists at global level.

By what I could gather, it tries to locate the user-fixes.py file in the base directory (not in the 'scripts' directory). Is your file located there?

"-file:lista.txt" contain the list of articles where the bot works on.

"-fix:carattericontrollo" is a set of replacements contents in user-fixes.py. This file exists in my core base directory.

The only output message is

Available predefined fixes are: ...

Not "The user fixes file could not be found: …" or other

I did a quick test with the latest version and it seems to be working.

This is a quick example I tried in user-fixes.py (excluding imports etc.):

fixes.update({
    'XXXX': {
        'regex': True,
        'msg': 'pywikibot-fixes-html',
        'replacements': [
            (r'(?i)([\r\n]) *<h6> *([^<]+?) *</h6> *([\r\n])',  r"\1====== \2 ======\3"),
        ],
        'exceptions': {
            'inside-tags': [
                'nowiki',
                'comment',
                'math',
                'pre'
            ],
        }
    }
}
)

When using an invalid fix name, I can see my fix listed:

Available predefined fixes are: correct-ar, isbn, HTML, case-de, datum, syntax, grammar-de, syntax-safe, specialpages, fckeditor, XXXX, vonbis, music, yu-tld

Okay then your user fixes may be invalid. Can you it maybe paste it somewhere (phabricator has a builtin paste service)?

Following the example of Malafaya I edited my user-fixes.py file from:

fixes = { ... }

fixes.update({ ... })

Now it works.
Thanks to all! :)

Ah shoot. I might have an explanation why it stopped working for you. In 3ac1880 I moved loading the file into a function and so my guess is that when you define fixes like you did, that it becomes a function local variable. I guess adding global fixes above the try would fix this problem properly. (Unless we want to say that it shouldn't be allowed)