Page MenuHomePhabricator

Add patch support to make-release
Closed, ResolvedPublic

Description

Right now security releases are a pain in the butt because we have to stop halfway through, apply a bunch of patches, then resume building.

Right now my idea is to add a --patch-dir option to make-release so it can have a directory of patch files to apply. The directory structure could look something like:

./core/T1234.patch
./skins/monobook/T4321.patch
./extensions/Example/T9876.patch

Event Timeline

demon claimed this task.
demon raised the priority of this task from to High.
demon updated the task description. (Show Details)
demon added subscribers: demon, csteipp.
greg rescinded a token.
greg awarded a token.

That sounds nice.

My only suggestion would be to have the branch name significant in the filename, so we can have a directory of all the patches in one place. If a branch patch isn't found in the directory, then skip it for this branch (probably). E.g.,

./core/T1234-REL1_26.patch
./core/T1234-REL1_25.patch
./core/T1234-REL1_23.patch
./skins/monobook/T4321.patch
./skins/monobook/T4321-REL1_26.patch
./extensions/Example/T9876.patch
...

Will do. I figured originally you'd just have a tree per release but that makes even more sense.

Change 246809 had a related patch set uploaded (by Chad):
Implement patch support for make-release

https://gerrit.wikimedia.org/r/246809

Change 246809 merged by jenkins-bot:
Implement patch support for make-release

https://gerrit.wikimedia.org/r/246809

demon added a project: OKR-Work.