Page MenuHomePhabricator
Create Task
Maniphest T117434

Phabricator should recognize "Bug: Tnnn" in commit messages same as "refs Tnnn" and connect the commit to the task
Closed, DeclinedPublic
Actions

Description

Phabricator should recognize "Bug: Tnnn" in commit messages same as "refs Tnnn" and connect the commit to the task.

While it's possible to configure various prefixes/suffixes to do things, such as "fixed Tnnn" to resolve the task, using maniphest.statuses, "refs" and some other ones are hardcoded in ManiphestTaskStatus::getStatusPrefixMap(). https://secure.phabricator.com/T5586 is the upstream request to make them configurable.

(T55387 is vaguely related.)

Related Objects

Event Timeline

matmarex created this task.Nov 2 2015, 4:39 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: Phabricator.
matmarex added subscribers: matmarex, • chasemp, faidon.
Restricted Application added subscribers: scfc, Aklapper. · View Herald TranscriptNov 2 2015, 4:39 PM
• mmodell subscribed.Nov 2 2015, 4:41 PM

This is an oddity of gerrit, why was gerrit coded to use a different format from what phabricator calls for?

matmarex updated the task description. (Show Details)Nov 2 2015, 4:41 PM
matmarex set Security to None.
matmarex added subscribers: Legoktm, Krinkle.Nov 2 2015, 4:54 PM
faidon added a comment.Nov 2 2015, 5:02 PM

Well, both Gerrit and "Bug:" predate Phabricator for one. Plus, "Bug:" is the correct way of adding Git metadata, so Phabricator is the odd one here. Also see the discussion here, as pointed out by @Legoktm.

Negative24 subscribed.Nov 5 2015, 1:54 AM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 5 2015, 1:54 AM
Negative24 awarded a token.Nov 5 2015, 1:54 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 2 2016, 7:59 PM
• mmodell triaged this task as Low priority.Jan 31 2018, 10:49 PM
• mmodell moved this task from To Triage to Misc on the Phabricator board.

This is no longer an issue AFAIK, phabricator now has "Related Objects" which includes tasks with Bug: Tnnn metadata under the Mentions heading.

Aklapper lowered the priority of this task from Low to Lowest.Aug 29 2018, 6:18 PM
Aklapper moved this task from Misc to Needs code (in Phab or bot) on the Phabricator board.

Proposing to decline as "Related Objects" exists.

Aklapper closed this task as Declined.Fri, Apr 26, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL