Page MenuHomePhabricator
Create Task
Maniphest T118733

[Wiktionary] Show a non-modal floating window upon highlighting text.
Closed, InvalidPublic3 Estimated Story Points
Actions

Description

When the user begins to highlight text (i.e. when the ActionMode is entered), fade in a blank window (with bottom gravity) with a height of, say, a third of the display height.

Details

SubjectRepoBranchLines +/-
WIP: Implement Wiktionary definition dialogapps/android/wikipediamaster+656 -29
Customize query in gerrit

Event Timeline

Dbrant created this task.Nov 16 2015, 3:29 PM
Dbrant raised the priority of this task from to Medium.
Dbrant updated the task description. (Show Details)
Dbrant added a project: Wikipedia-Android-App-Backlog.
Dbrant moved this task to Next Sprint on the Wikipedia-Android-App-Backlog board.
Dbrant subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2015, 3:29 PM
Dbrant added a parent task: T115484: Display definitions of highlighted words from Wiktionary.Nov 16 2015, 3:39 PM
MBinder_WMF added a project: OKR-Work.Nov 20 2015, 6:38 PM
MBinder_WMF set Security to None.
MBinder_WMF edited a custom field.Nov 20 2015, 6:41 PM
Dbrant moved this task from Next Sprint to Current Sprint on the Wikipedia-Android-App-Backlog board.Nov 23 2015, 10:59 PM
Dbrant added a project: Mobile-App-Android-Sprint-71-Lutetium.
• Mholloway claimed this task.Dec 1 2015, 6:33 PM
• Mholloway moved this task from To Do to Doing on the Mobile-App-Android-Sprint-71-Lutetium board.
gerritbot subscribed.Dec 4 2015, 5:11 PM

Change 256959 had a related patch set uploaded (by Mholloway):
WIP: Implement Wiktionary definition dialog

https://gerrit.wikimedia.org/r/256959

gerritbot added a project: Patch-For-Review.Dec 4 2015, 5:11 PM
gerritbot added a comment.Dec 4 2015, 10:51 PM

Change 256959 abandoned by Mholloway:
WIP: Implement Wiktionary definition dialog

Reason:
Not even half-baked.

https://gerrit.wikimedia.org/r/256959

Dbrant edited projects, added Mobile-App-Android-Sprint-72-Hafnium; removed Mobile-App-Android-Sprint-71-Lutetium.Dec 7 2015, 4:14 PM
Dbrant moved this task from To Do to Doing on the Mobile-App-Android-Sprint-72-Hafnium board.
gerritbot added a comment.Dec 8 2015, 9:02 PM

Change 257695 had a related patch set uploaded (by Mholloway):
Implement Wiktionary definition dialog

https://gerrit.wikimedia.org/r/257695

• Mholloway moved this task from Doing to Code Review on the Mobile-App-Android-Sprint-72-Hafnium board.Dec 8 2015, 9:47 PM
Dbrant removed a project: Mobile-App-Android-Sprint-72-Hafnium.Dec 18 2015, 7:02 PM
Dbrant moved this task from Current Sprint to Product Backlog on the Wikipedia-Android-App-Backlog board.Dec 18 2015, 8:31 PM
Dbrant removed a parent task: T115484: Display definitions of highlighted words from Wiktionary.Mar 7 2016, 2:47 PM
• Mholloway removed • Mholloway as the assignee of this task.May 12 2017, 2:40 AM
• Mholloway subscribed.

Are we leaving this open to switch to a non-modal window? In any case I'll remove myself as the assignee in the meantime.

Dbrant closed this task as Invalid.Sep 6 2017, 12:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL