Page MenuHomePhabricator
Create Task
Maniphest T119215

Make link preview geolocation-aware.
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

  1. For articles that have a geolocation (as provided by MCS, or by the Nearby fragment), the link preview shall display an option in overflow menu that says "Get directions". Clicking this will take the user to the default Maps app (e.g. Google Maps) with an intent containing the target location.
  1. When invoked from NearbyFragment, and the user's location is enabled, the link preview shall display the option "Get Directions" directly on the sheet, instead of the overflow menu. The button will appear as an action next to "Read article".

See Article Sheets

  • M118 Android bottom sheets
    20

    • Details

    SubjectRepoBranchLines +/-
    Location-aware link previews.apps/android/wikipediamaster+90 -17
    Customize query in gerrit

    Related Objects

    Event Timeline

    Dbrant created this task.Nov 20 2015, 6:02 PM
    Dbrant raised the priority of this task from to Needs Triage.
    Dbrant updated the task description. (Show Details)
    Dbrant added a project: Wikipedia-Android-App-Backlog.
    Dbrant moved this task to Next Sprint on the Wikipedia-Android-App-Backlog board.
    Dbrant subscribed.
    Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 20 2015, 6:02 PM
    MBinder_WMF edited projects, added OKR-Work; removed Wikipedia-Android-App-Backlog.Nov 20 2015, 6:58 PM
    MBinder_WMF set Security to None.
    MBinder_WMF edited a custom field.
    MBinder_WMF added projects: Wikipedia-Android-App-Backlog, Mobile-App-Android-Sprint-71-Lutetium.
    MBinder_WMF edited a custom field.
    MBinder_WMF edited a custom field.
    Dbrant moved this task from Next Sprint to Current Sprint on the Wikipedia-Android-App-Backlog board.Nov 23 2015, 10:59 PM
    • KHammerstein updated the task description. (Show Details)Nov 23 2015, 11:41 PM
    Dbrant mentioned this in T117803: [Dev] Upgrade MapBox SDK.Nov 25 2015, 7:08 PM
    Dbrant claimed this task.Dec 1 2015, 4:56 PM
    Dbrant moved this task from To Do to Doing on the Mobile-App-Android-Sprint-71-Lutetium board.
    gerritbot subscribed.Dec 1 2015, 6:42 PM

    Change 256266 had a related patch set uploaded (by Dbrant):
    WIP: Location-aware link previews.

    https://gerrit.wikimedia.org/r/256266

    gerritbot added a project: Patch-For-Review.Dec 1 2015, 6:42 PM
    Dbrant moved this task from Doing to Code Review on the Mobile-App-Android-Sprint-71-Lutetium board.Dec 1 2015, 10:09 PM
    gerritbot added a comment.Dec 2 2015, 6:57 PM

    Change 256266 merged by jenkins-bot:
    Location-aware link previews.

    https://gerrit.wikimedia.org/r/256266

    Dbrant moved this task from Code Review to Design Signoff on the Mobile-App-Android-Sprint-71-Lutetium board.Dec 2 2015, 7:17 PM
    • KHammerstein subscribed.Dec 4 2015, 6:36 PM

    @Dbrant Is this available in link preview overflow menus yet? Checking the latest apk from Dec 4.

    Dbrant added a comment.Dec 4 2015, 7:01 PM

    @KHammerstein Good catch; that part of it will actually need to be delayed a bit, since it will need some updates in the content service. It will be done in a separate patch.

    • KHammerstein moved this task from Design Signoff to QA Signoff on the Mobile-App-Android-Sprint-71-Lutetium board.Dec 4 2015, 7:09 PM
    Dbrant moved this task from QA Signoff to Done on the Mobile-App-Android-Sprint-71-Lutetium board.Dec 7 2015, 4:03 PM
    Dbrant closed this task as Resolved.Dec 7 2015, 4:10 PM
    Dbrant moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Dec 10 2015, 4:21 PM
    Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL