Page MenuHomePhabricator
Create Task
Maniphest T121251

Using JS to prevent double html form submissions
Open, MediumPublic
Actions

Description

Double clicking "submit" very quickly on ChangePassword/ResetPassword/Preferences causes "CAS update failed on user_touched for user ID '25080093' (read from slave); the version of the user to be saved is older than the current version." There is no use in sending duplicate requests. This should be debounced by locking the button.

Related Objects

Event Timeline

aaron created this task.Dec 11 2015, 6:16 PM
aaron raised the priority of this task from to Needs Triage.
aaron updated the task description. (Show Details)
aaron added a project: MediaWiki-Core-Preferences.
aaron added subscribers: aaron, Krinkle.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 11 2015, 6:16 PM
Krinkle renamed this task from Using JS to prevent double form submissions to avoid CAS errors to Using JS to prevent double html form submissions.Dec 15 2015, 12:05 AM
Krinkle edited projects, added MediaWiki-HTMLForm, MediaWiki-User-Interface; removed MediaWiki-Core-Preferences.
Krinkle set Security to None.

The CAS token issue is resolved with locking per T95839, but we should still avoid these double posts to begin with.

Krinkle triaged this task as Medium priority.Dec 15 2015, 12:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL