Dashiki: Add extension and category (ala Eventlogging) for DashikiConfigs
Description
Details
Related Objects
Event Timeline
Change 323178 had a related patch set uploaded (by Milimetric):
Implement basic Dashiki extension
Remains to be done:
- Deploy to beta
- Deploy to test wiki
- Test
- Deploy to production
Enable extension by enabling json config
Change 333086 had a related patch set uploaded (by Milimetric):
Test mediawiki-Dashiki on the beta cluster
Please follow the checklist at https://www.mediawiki.org/wiki/Review_queue, thanks! Notably, security review is needed before deploying to Beta Cluster.
@greg I did ask whether security review was required on this extension's original patch, and added Darian, but didn't get a clear answer. It seemed to me this was too simple to need security review, but how should I make sure? Ping Darian? I did try to stick to that checklist as closely as possible, I got a little lost in details.
Nothing is too simple for security review, but it's simple enough that I reviewed it in about 2 minutes. {{approved}} and will deploy to Beta today.
Thank you for the merge. I've created https://deployment.wikimedia.beta.wmflabs.org/wiki/Dashiki:TestConfig to test, looks like it's either not working or not deployed yet, will follow up later.
According to https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:Version is it installed.
I'm an idiot, it works perfectly fine https://deployment.wikimedia.beta.wmflabs.org/wiki/Config:Dashiki:TestConfig, I'll wait a while and work on deploying this to meta.
Currently in stage https://www.mediawiki.org/wiki/Review_queue#Preparing_for_deployment where I have to first get community consensus for deploying. Which is happening here:
https://meta.wikimedia.org/wiki/Meta:Babel#Enabling_Dashiki_Extension_on_Meta_wiki
After a positive discussion on meta's Babel page, created T156971 to track deployment to prod.
This has been deployed, and works as expected: https://meta.wikimedia.org/wiki/Config:Dashiki:Sample/tabs
I will spend some time migrating all configurations over to the new sub-namespace and removing the old ones once dashboards are deployed.