Page MenuHomePhabricator
Create Task
Maniphest T126010

Source code background spreads across the border
Closed, ResolvedPublic
Actions

Description

In this page the block of source code has a grey background, which spreads over the border, but it must not.
Chrome 48, OS Linux: screenshot

Details

SubjectRepoBranchLines +/-
Avoid background when the content is narrowmediawiki/extensions/SyntaxHighlight_GeSHimaster+5 -0
Syntaxhighlight: avoid double backgroundmediawiki/extensions/SyntaxHighlight_GeSHimaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Yanpas created this task.Feb 5 2016, 5:47 PM
Yanpas raised the priority of this task from to Medium.
Yanpas updated the task description. (Show Details)
Yanpas subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2016, 5:47 PM
Krenair added a project: SyntaxHighlight.Feb 5 2016, 6:12 PM
Krenair subscribed.
TheDJ subscribed.Apr 27 2017, 4:25 PM

This is caused by the background on the mw-highlight element... There is already a background on it's sibling <pre> as well. Maybe we should just remove this higher level one.

gerritbot subscribed.Apr 27 2017, 4:42 PM

Change 350602 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Avoid background when the content is narrow

https://gerrit.wikimedia.org/r/350602

gerritbot added a project: Patch-For-Review.Apr 27 2017, 4:42 PM
Krinkle closed this task as Resolved.Apr 28 2017, 9:02 PM
Krinkle assigned this task to TheDJ.
Krinkle moved this task from Backlog to Accepted on the SyntaxHighlight board.
gerritbot added a comment.Apr 28 2017, 9:07 PM

Change 350602 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Avoid background when the content is narrow

https://gerrit.wikimedia.org/r/350602

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).Apr 28 2017, 10:00 PM
gerritbot added a comment.Feb 9 2020, 7:19 PM

Change 571083 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Syntaxhighlight: avoid double background

https://gerrit.wikimedia.org/r/571083

TheDJ mentioned this in T237190: style="overflow:auto" should be applied directly to the <source>.Feb 9 2020, 7:21 PM
gerritbot added a comment.Feb 9 2020, 7:26 PM

Change 571083 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Syntaxhighlight: avoid double background

https://gerrit.wikimedia.org/r/571083

TheDJ mentioned this in rESHG0c4e7b21ac8c: Syntaxhighlight: avoid double background.Feb 9 2020, 7:35 PM
Izno mentioned this in T365927: SyntaxHighlight's background is a bit too expansive.Sat, May 25, 11:31 PM
Maintenance_bot removed a project: Patch-For-Review.Sun, May 26, 12:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL