Page MenuHomePhabricator
Create Task
Maniphest T134515

"updated since my last visit" marker (updatedmarker) not styled in MW core, Vector
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Catrope
May 5 2016, 6:18 PM
Tags
Referenced Files
F3970751: pasted_file
May 5 2016, 8:06 PM
F3970454: updatedmarker-monobook.png
May 5 2016, 6:18 PM
F3970456: updatedmarker-enwiki.png
May 5 2016, 6:18 PM
F3970452: updatedmarker-mediawiki.png
May 5 2016, 6:18 PM
Subscribers
Aklapper
Catrope
Edokter
Entlinkt
gerritbot
He7d3r
Jdlrobson
View All 13 Subscribers

Description

The "updated since my last visit" marker appears on the history page for pages on your watchlist (invoked by ?action=history), and marks edits that have happened since you last viewed the page. This marker used to be styled with a green background highlight (#00ff00), like this:

updatedmarker-monobook.png (21×277 px, 2 KB)

It's still styled that way in Monobook and Modern, but in Vector it's not styled at all:

updatedmarker-mediawiki.png (21×295 px, 3 KB)

Meanwhile, English Wikipedia has styled it differently, with a text color instead of a background color, and with a different green (#006400), but only in Vector:

updatedmarker-enwiki.png (32×300 px, 3 KB)

Details

SubjectRepoBranchLines +/-
Remove updatedmarker styling overridemediawiki/skins/Modernmaster+0 -5
Remove updatedmarker styling overridemediawiki/skins/MonoBookmaster+0 -5
Clean up updatedmarker styling messmediawiki/coremaster+2 -7
Fix unstyled updatedmarkermediawiki/coremaster+5 -0
Improve unstyled updatedmarkermediawiki/coremaster+2 -3
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.May 5 2016, 6:18 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 5 2016, 6:18 PM
gerritbot subscribed.May 5 2016, 6:18 PM

Change 287043 had a related patch set uploaded (by Catrope):
Fix unstyled updatedmarker

https://gerrit.wikimedia.org/r/287043

gerritbot added a project: Patch-For-Review.May 5 2016, 6:18 PM
Catrope added a subscriber: Edokter.May 5 2016, 6:25 PM
In T134515#2267925, @gerritbot wrote:

Change 287043 had a related patch set uploaded (by Catrope):
Fix unstyled updatedmarker

https://gerrit.wikimedia.org/r/287043

This patch applies the green background styling (first screenshot in the task description) in MW core. @Edokter says it burns his eyes and suggests using the enwiki style (dark green text color) instead.

Catrope updated the task description. (Show Details)May 5 2016, 6:27 PM
MGChecker subscribed.May 5 2016, 6:27 PM
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptMay 5 2016, 6:27 PM
Edokter added a comment.May 5 2016, 7:58 PM

If we're not touching the colors set in the other skins, they will override this, and the colors set in enwiki's common.css will have to remain.

matmarex subscribed.May 5 2016, 8:06 PM

Commons offers a middle ground (#99D642):

pasted_file (23×263 px, 2 KB)

Jdlrobson triaged this task as Low priority.May 9 2016, 5:12 PM
Jdlrobson subscribed.

@Catrope feel free to update priority if you feel wrong.

MBinder_WMF added a project: Web-Team-Backlog.May 17 2016, 6:30 PM
• Jhernandez added a project: Design.May 18 2016, 3:24 PM
• Jhernandez moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
gerritbot added a comment.May 18 2016, 5:59 PM

Change 287043 merged by jenkins-bot:
Fix unstyled updatedmarker

https://gerrit.wikimedia.org/r/287043

matmarex closed this task as Resolved.May 18 2016, 6:17 PM
matmarex assigned this task to Catrope.
Volker_E updated the task description. (Show Details)May 18 2016, 8:17 PM
gerritbot added a comment.May 18 2016, 8:37 PM

Change 289549 had a related patch set uploaded (by VolkerE):
Improve unstyled updatedmarker

https://gerrit.wikimedia.org/r/289549

Volker_E reopened this task as Open.May 18 2016, 8:37 PM
Volker_E claimed this task.
gerritbot added a comment.May 20 2016, 4:15 PM

Change 289549 merged by jenkins-bot:
Improve unstyled updatedmarker

https://gerrit.wikimedia.org/r/289549

Jdlrobson closed this task as Resolved.May 20 2016, 4:56 PM
ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)), MW-1.28-release-notes.May 24 2016, 11:34 AM
TheDJ subscribed.May 26 2016, 11:14 PM

This unintentionally showed up on en.wp, because the patch uses span.updatedmarker, whereas english wikipedia was using just .updatedmarker

To quote a user:

aaaaaaaah make it stop before my retinas burn off

And another remark:

The obvious design here is to eliminate those messages and draw a horizontal line above which all edits are "new".

Volker_E added a comment.May 26 2016, 11:21 PM

@TheDJ Sorry, the patch uses .updatedmarker, which I explicitely changed to get away from this formerly good, now seen as bad pattern. To clarify, are you citing comments on the before or after patch state situation?

PeterBowman subscribed.May 26 2016, 11:42 PM
He7d3r subscribed.May 27 2016, 1:02 PM
He7d3r added a project: User-notice.May 27 2016, 1:14 PM
Entlinkt subscribed.May 27 2016, 2:50 PM
In T134515#2313017, @gerritbot wrote:

Change 289549 merged by jenkins-bot:
Improve unstyled updatedmarker

https://gerrit.wikimedia.org/r/289549

This patch only applies to the CologneBlue skin. Is that really the intention?

Edokter added a comment.May 27 2016, 3:21 PM

It applies to all skins. But can we decide on a unified selector please?

TheDJ added a comment.May 27 2016, 3:29 PM

@Volker_E there are two definitions of this rule, you only changed the one to .updatedmarker, but not the other one in resources/src/mediawiki.action/mediawiki.action.history.css

Entlinkt added a comment.May 27 2016, 3:29 PM
In T134515#2334143, @Edokter wrote:

It applies to all skins.

I don't think that resources/src/mediawiki.legacy/oldshared.css applies to all skins. The wrong file has been patched.

matmarex added a comment.May 27 2016, 3:33 PM

Uhh, yeah. The original patch (https://gerrit.wikimedia.org/r/#/c/287043/) added the rule to resources/src/mediawiki.action/mediawiki.action.history.css. The follow-up patch (https://gerrit.wikimedia.org/r/#/c/289549/) modified resources/src/mediawiki.legacy/oldshared.css.

matmarex reopened this task as Open.May 27 2016, 3:34 PM
Jdlrobson edited projects, added UI-Standardization-Kanban, UI-Standardization; removed Patch-For-Review.May 27 2016, 9:58 PM
Jdlrobson added a comment.May 27 2016, 10:00 PM
In T134515#2334163, @matmarex wrote:

Uhh, yeah. The original patch (https://gerrit.wikimedia.org/r/#/c/287043/) added the rule to resources/src/mediawiki.action/mediawiki.action.history.css. The follow-up patch (https://gerrit.wikimedia.org/r/#/c/289549/) modified resources/src/mediawiki.legacy/oldshared.css.

Thanks for clarifying. Confusing.
Is there a more suitable place for this rule to live and be shared by both pages and skins?

Entlinkt added a comment.May 28 2016, 9:51 AM

It would be really nice if software developers would think what they intend to do, and test whether their patches actually meet the intentions. Especially if it's something so easy to test as a background color. This is what happened so far:

SkinBackground color before the two patches (has been that way for many years)Background color after gerrit:287043 (never went live on production sites)Background color after gerrit:289549 (currently live on production sites)Actually intended background color
Vectortransparent#0f0#0f0?
Monobook#0f0#0f0#0f0?
Modern#0f0#0f0#0f0?
Cologneblue#0f0#0f0short flash of #b7f430, then #0f0?

From the German-language Wikipedia I can report that there is very negative feedback about the switch from "transparent" to "#0f0" in the Vector skin. I have therefore applied a local hack that sets the background color to "#b7f430" for Vector users in the assumption that this is what you intended.

This is maybe a bit better (#0f0 is just unacceptable), but there are still users complaining that they don't need any highlighting at all, asking for instructions how to remove it.

gerritbot added a comment.May 28 2016, 3:24 PM

Change 291514 had a related patch set uploaded (by Bartosz Dziewoński):
Clean up updatedmarker styling mess

https://gerrit.wikimedia.org/r/291514

gerritbot added a project: Patch-For-Review.May 28 2016, 3:24 PM

Change 291515 had a related patch set uploaded (by Bartosz Dziewoński):
Remove updatedmarker styling override

https://gerrit.wikimedia.org/r/291515

gerritbot added a comment.May 28 2016, 3:25 PM

Change 291516 had a related patch set uploaded (by Bartosz Dziewoński):
Remove updatedmarker styling override

https://gerrit.wikimedia.org/r/291516

matmarex added a comment.May 28 2016, 3:28 PM

With these patches, the updatedmarker has a #b7f430 background on all WMF-deployed skins, and there is only one place we need to change if we want to use a different color.

gerritbot added a comment.May 28 2016, 5:35 PM

Change 291514 merged by jenkins-bot:
Clean up updatedmarker styling mess

https://gerrit.wikimedia.org/r/291514

gerritbot added a comment.May 28 2016, 5:52 PM

Change 291515 merged by jenkins-bot:
Remove updatedmarker styling override

https://gerrit.wikimedia.org/r/291515

Volker_E added a comment.May 28 2016, 5:54 PM

@Entlinkt Would you point me to the negative feedback on use of background-color here, that you were mentioning?

gerritbot added a comment.May 28 2016, 8:06 PM

Change 291516 merged by jenkins-bot:
Remove updatedmarker styling override

https://gerrit.wikimedia.org/r/291516

matmarex closed this task as Resolved.May 28 2016, 8:56 PM
matmarex removed a project: Patch-For-Review.
matej_suchanek moved this task from To Triage to Announce in next Tech/News on the User-notice board.May 29 2016, 6:42 PM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 6:58 PM
Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Jun 2 2016, 3:51 AM
Entlinkt added a comment.Jun 2 2016, 6:00 PM

The negative feedback was, amongst others, here and there.

I think it has mostly cooled down after I applied the change from #0f0 to #b7f430 as a local hack. Since that change has now been done for all skins, it should be fine.

Volker_E moved this task from Backlog to Done on the UI-Standardization-Kanban board.Jun 7 2016, 5:08 PM
Johan moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Jun 8 2016, 1:15 PM
Johan moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Jun 10 2016, 5:10 PM
matmarex mentioned this in T137383: .updatedmarker is not styled without JavaScript.Jun 13 2016, 7:31 PM
• Phabricator_maintenance moved this task from Needs Prioritization to 2015-16 Q4 on the Web-Team-Backlog board.Mar 6 2018, 11:54 PM
Aklapper edited projects, added MediaWiki-Page-history; removed MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Sep 20 2019, 7:48 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL