Page MenuHomePhabricator
Create Task
Maniphest T141330

?oldid=mostRecentRevId causes strange behavior on second edit
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

  1. Go to /wiki/Some_page?oldid=123 where 123 is the oldid of the most recent revision (e.g. https://en.wikipedia.org/w/index.php?title=User:Roan_Kattouw_(WMF)/Sandbox&oldid=731550113 ; go to the history and click the topmost timestamp)
  2. Click the edit tab to open VE
  3. Make changes
  4. Save
  5. Click edit again
  6. Be surprised that you're in oldid mode and don't see the changes you just made

If you do this with any other oldid (i.e. the ID of an actually-old revision), you will now be editing the most recent revision of the page. However, because the oldid is the most recent ID, VE gets confused and goes into oldid mode. We should never be in oldid mode on the second edit.

Details

SubjectRepoBranchLines +/-
Reduce mayhem caused by ?oldid=currentRevIdmediawiki/extensions/VisualEditormaster+31 -14
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Jul 26 2016, 2:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2016, 2:16 AM
Catrope added a comment.Jul 26 2016, 2:19 AM

Turns out Timo realized something was wrong when he wrote this code back in 2013: https://gerrit.wikimedia.org/r/#/c/72070/12/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js@402 (that comment is still there in DesktopArticleTarget#saveComplete)

gerritbot subscribed.Jul 26 2016, 3:09 AM

Change 301056 had a related patch set uploaded (by Catrope):
Reduce mayhem caused by ?oldid=currentRevId

https://gerrit.wikimedia.org/r/301056

Catrope mentioned this in T134593: Intermittent corruptions on saves, likely related to data-parsoid mis-matches.Jul 26 2016, 3:11 AM
gerritbot added a comment.Jul 26 2016, 3:36 AM

Change 301056 merged by jenkins-bot:
Reduce mayhem caused by ?oldid=currentRevId

https://gerrit.wikimedia.org/r/301056

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)).Jul 26 2016, 4:00 AM
Jdforrester-WMF closed this task as Resolved.Jul 26 2016, 4:17 PM
Jdforrester-WMF assigned this task to Catrope.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL