Special:Notifications broken when EventLogging extension is not enabled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-leszek
	Aug 16 2016, 11:05 AM

Description

When trying to open Special:Notifications on current master (8947629f527f9486ae3e8713de6b8ed98b4dbf95) I am getting an error:

PHP Fatal error:  Class 'EventLogging' not found in (...)/extensions/Echo/includes/EventLogging.php on line 16

I don't have EventLogging extension enabled on my wiki but previously it hasn't affected the way Echo worked.

Apparently there is a check missing before logging added in Icfe63fb8daa8e8fba029e22b4de3e4f65517c448 which leads to a crash.

	Subject	Repo	Branch	Lines +/-
	Make server-side logging always check whether schema is enabled	mediawiki/extensions/Echo	master	+14 -19
	Check if logging is enabled before logging EchoInteraction	mediawiki/extensions/Echo	master	+25 -13

Mentioned In: T186427: Special:UploadWizard Campaigns broken when EventLogging extension is not enabled

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 305005 had a related patch set uploaded (by WMDE-leszek):
Check if logging is enabled before logging Special:Notifcations page visit

Change 305005 merged by jenkins-bot:
Check if logging is enabled before logging EchoInteraction

Checked locally - no crashes.

Change 305603 had a related patch set uploaded (by Mattflaschen):
Make server-side logging always check whether schema is enabled

Change 305603 merged by jenkins-bot:
Make server-side logging always check whether schema is enabled