Page MenuHomePhabricator
Create Task
Maniphest T154572

OOjs UI colorized SVG icons are affected by libRSVG bug
Closed, ResolvedPublic
Actions

Description

Unfortunately the icons using the style tag element. I strongly suggest to use an inline style notation, either as SVG attribute or inline CSS (it is also a baseless to use globale CSS for a single SVG element). Examples:

T68672 - libRSVG bug (strangely first in 2014)

Additional there are some more (global) style-tag bugs for the libRSVG e.g. https://commons.wikimedia.org/wiki/Help:SVG#Font_styling_class

Details

SubjectRepoBranchLines +/-
colorize-svg: Colorize using a method compatible with rsvgoojs/uimaster+8 -7
Customize query in gerrit

Related Objects

Event Timeline

Perhelion created this task.Jan 4 2017, 10:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2017, 10:08 AM
Perhelion updated the task description. (Show Details)Jan 4 2017, 10:18 AM
Volker_E moved this task from Unsorted to OOUI on the UI-Standardization board.Jan 5 2017, 10:38 PM
matmarex renamed this task from OOjs-UI SVG icons are affected of libRSVG bug to OOjs-UI colorized SVG icons are affected by libRSVG bug.Jan 19 2017, 12:17 PM
matmarex edited projects, added JavaScript, good first task; removed UI-Standardization, CSS.Jan 19 2017, 12:23 PM
matmarex subscribed.

In MediaWiki's code for colorizing icons, we actually use a different method, which works with rsvg: we wrap the entire SVG in a <g fill="whatever"></g> (ResourceLoaderImage::variantize).

That could be adapted into OOjs UI's /build/tasks/colorize-svg.js script.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJan 19 2017, 12:23 PM
Volker_E renamed this task from OOjs-UI colorized SVG icons are affected by libRSVG bug to OOjs UI colorized SVG icons are affected by libRSVG bug.Feb 7 2017, 2:50 AM
gerritbot subscribed.Feb 7 2017, 4:01 PM

Change 336424 had a related patch set uploaded (by Bartosz Dziewoński):
colorize-svg: Colorize using a method compatible with rsvg

https://gerrit.wikimedia.org/r/336424

gerritbot added a project: Patch-For-Review.Feb 7 2017, 4:01 PM
gerritbot added a comment.Feb 7 2017, 9:18 PM

Change 336424 merged by jenkins-bot:
colorize-svg: Colorize using a method compatible with rsvg

https://gerrit.wikimedia.org/r/336424

Volker_E closed this task as Resolved.Feb 28 2017, 9:57 PM
Volker_E assigned this task to matmarex.
Volker_E moved this task from Backlog to OOjs-UI-0.19.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOjs-UI-0.19.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL