Page MenuHomePhabricator
Create Task
Maniphest T158321

VisualEditor Cite dialog, when Ctrl+Enter is pressed, inserts a newline before closing the dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In VisualEditor, when the Cite dialog is in use ("Basic Form"), the keystroke equivalent Ctrl+Enter is supposed to close the dialog. It does close the dialog, but it also inserts a newline character into the citation at the cursor position. That insertion should not happen.

Verified on Wikipedia today in the latest Firefox on Windows 7 Professional, and on a MediaWiki 1.28 server using Linux Chrome. The bug is present in MediaWiki 1.28.1 and 1.29.0-wmf.11 (rMWfa8cb272dc79).

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (813c586a6)mediawiki/extensions/VisualEditormaster+1 -1
LinearEnterKeyDownHandler: abort if in dialog and ctrl/cmd heldVisualEditor/VisualEditormaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

maiden_taiwan created this task.Feb 16 2017, 4:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2017, 4:15 PM
gerritbot subscribed.Feb 21 2017, 4:53 PM

Change 338994 had a related patch set uploaded (by DLynch):
LinearEnterKeyDownHandler: abort if in dialog and ctrl/cmd held

https://gerrit.wikimedia.org/r/338994

gerritbot added a project: Patch-For-Review.Feb 21 2017, 4:53 PM
gerritbot added a comment.Feb 23 2017, 7:35 PM

Change 338994 merged by jenkins-bot:
LinearEnterKeyDownHandler: abort if in dialog and ctrl/cmd held

https://gerrit.wikimedia.org/r/338994

gerritbot added a comment.Feb 23 2017, 7:38 PM

Change 339481 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481

gerritbot added a comment.Feb 23 2017, 8:02 PM

Change 339481 merged by jenkins-bot:
Update VE core submodule to master (813c586a6)

https://gerrit.wikimedia.org/r/339481

Jdforrester-WMF closed this task as Resolved.Feb 23 2017, 8:08 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added Cite, VisualEditor-MediaWiki-References; removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added a project: MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)).Mar 3 2017, 12:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL