Page MenuHomePhabricator
Create Task
Maniphest T163425

RevisionSlider reloads diff needlessly when dragged back to original position
Closed, ResolvedPublic
Actions

Description

Taken from: https://www.mediawiki.org/w/index.php?title=Topic:Tox8ng2jqj6go7z9&topic_showPostId=toziizz11vu4i9qb#flow-post-toziizz11vu4i9qb

When dragging one of the pointers over another revision without releasing it and then returning it to the original position / revision the diff reloads although nothing changed.

Details

SubjectRepoBranchLines +/-
Fix unnecessary reloading of diffmediawiki/extensions/RevisionSlidermaster+17 -0
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Apr 20 2017, 9:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2017, 9:12 AM
Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Apr 25 2017, 10:13 AM
Lea_WMDE moved this task from Incoming to Backlog on the Revision-Slider board.May 8 2017, 12:19 PM
Lea_WMDE edited projects, added patch-welcome; removed WMDE-TechWish.Jun 7 2017, 2:49 PM
Lea_WMDE moved this task from Backlog to volunteer tasks on the Revision-Slider board.Jul 4 2017, 1:40 PM
WMDE-Fisch added a project: good first task.Aug 9 2017, 1:35 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 9 2017, 1:35 PM
gerritbot subscribed.Aug 12 2017, 3:38 PM

Change 371622 had a related patch set uploaded (by MtDu; owner: MtDu):
[mediawiki/extensions/RevisionSlider@master] Fix unnecessary reloading of diff

https://gerrit.wikimedia.org/r/371622

gerritbot added a project: Patch-For-Review.Aug 12 2017, 3:38 PM
MtDu mentioned this in rERSL276f6fd271ec: Fix unnecessary reloading of diff.Aug 12 2017, 3:40 PM
MtDu mentioned this in rERSL61e5d029cd94: Fix unnecessary reloading of diff.Aug 12 2017, 3:46 PM
gerritbot added a comment.Aug 12 2017, 3:52 PM

Change 371622 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Fix unnecessary reloading of diff

https://gerrit.wikimedia.org/r/371622

MtDu closed this task as Resolved.Aug 12 2017, 3:54 PM
MtDu claimed this task.
MtDu subscribed.

Code has been merged, so closing task as resolved. :)

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 21 2017, 5:02 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL