Page MenuHomePhabricator
Create Task
Maniphest T163724

persistently addable/editable/removable statements on a Form via the UI (L)
Closed, ResolvedPublic
Actions

Description

We want to be able to say more about each Form of a Lexeme by making statements about each Form. They should be persistently editable now.

Acceptance criteria:

  • At least 1 statement is shown for each Form with qualifiers, references and ranks. (Relevant for the demo)
  • I can edit all parts of the statement and save it. The edit survives a reload.
  • All parts of the statement look and act like statements on items.
  • Dokumented learnings on how this implementation can be re-used for other API-Modules
  • Re-use an existing API-Module for realising this story

Details

SubjectRepoBranchLines +/-
Let FormSet::add replace existing Form instead of failingmediawiki/extensions/WikibaseLexememaster+25 -22
Rename Lexeme::addForm to addNewFormmediawiki/extensions/WikibaseLexememaster+12 -12
Rename FormSet::add to setmediawiki/extensions/WikibaseLexememaster+11 -11
Enable skipped SetClaimTest with Formsmediawiki/extensions/WikibaseLexememaster+17 -23
Workaround EditFilterMergedContent hook assuming sub-entities have a Contentmediawiki/extensions/Wikibasemaster+17 -14
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata
 ResolvedAddshoreT168260 Deploy WikibaseLexeme extension on Wikimedia cluster
 ResolvedAddshoreT191457 Deploy WikibaseLexeme on www.wikidata.org
 ResolvedAddshoreT191458 Deploy WikibaseLexeme on test.wikidata.org
 ResolvedLydia_PintscherT168263 WikibaseLexeme functional baseline
 ResolvedLydia_PintscherT159703 [Tracking] Support for Forms and Senses
 ResolvedLydia_PintscherT150178 Wikidata 2017 Q2 goals
 ResolvedLydia_PintscherT169708 Wikidata 2017 Q3 goals
 ResolvedLydia_PintscherT160052 [Epic] Support for Forms
 ResolvedLydia_PintscherT160526 [Story] List of Statements for a Form
 ResolvedthiemowmdeT163724 persistently addable/editable/removable statements on a Form via the UI (L)
 ResolvedWMDE-leszekT179650 Investigation: Create a proof of concept making wbsetclaim API work with editing statements of forms
 ResolvedWMDE-leszekT179661 Investigation: Proof of concept of the ChangeOp for changing statements of a form (in case Form class is not implementing EntityDocument interface)
 ResolvedWMDE-leszekT179662 Investigation: Proof of concept making it possible to use WikibaseLexeme-specific code in wbsetclaim API action
 ResolvedthiemowmdeT180464 Investigation: If and how form IDs like F1 and L1-F1 should co-exist in the code base
 ResolvedthiemowmdeT180467 Make it possible to handle sub-entities in the storage layer of Wikibase (days: 1)
 ResolvedthiemowmdeT182097 Investigation: Whether it is better to skip permission checks for forms
 ResolvedthiemowmdeT180469 Make Forms and FormId implement Entity interfaces
 ResolvedNoneT180470 Adjust demo data of forms after statements on the form can be saved
 ResolvedWMDE-leszekT180471 Create tests for editing statements on Forms
 ResolvedNoneT181253 Make UI use wbsetclaim API for Form Statements

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Lydia_Pintscher removed a subtask: T165328: Allow entity sub-structures to be treated like entities (so called sub-entities)..Aug 21 2017, 4:05 PM
daniel added a subtask: T165328: Allow entity sub-structures to be treated like entities (so called sub-entities)..Aug 21 2017, 4:11 PM
WMDE-leszek raised the priority of this task from Medium to High.Oct 16 2017, 8:21 AM
WMDE-leszek added a project: Wikidata-Former-Sprint-Board.
WMDE-leszek moved this task from Proposed to Backlog on the Wikidata-Former-Sprint-Board board.
• Jonas updated the task description. (Show Details)Oct 24 2017, 12:16 PM
Franziska_Heine updated the task description. (Show Details)Oct 24 2017, 12:33 PM
Franziska_Heine renamed this task from [Story] persistently editable statements on a Form to [Story] persistently editable statements on a Form (L).Oct 24 2017, 12:37 PM
Lydia_Pintscher removed a subtask: T165328: Allow entity sub-structures to be treated like entities (so called sub-entities)..Oct 24 2017, 2:27 PM
Lydia_Pintscher moved this task from incoming to big tasks on the Wikidata Lexicographical data board.Oct 24 2017, 2:35 PM
Lydia_Pintscher renamed this task from [Story] persistently editable statements on a Form (L) to persistently editable statements on a Form (L).Oct 24 2017, 3:16 PM
Lydia_Pintscher renamed this task from persistently editable statements on a Form (L) to persistently editable statements on a Form via the UI (L).Oct 24 2017, 3:34 PM
Lydia_Pintscher renamed this task from persistently editable statements on a Form via the UI (L) to persistently addable/editable/removable statements on a Form via the UI (L).Oct 24 2017, 3:42 PM
WMDE-leszek created subtask T179650: Investigation: Create a proof of concept making wbsetclaim API work with editing statements of forms.Nov 3 2017, 9:40 AM
Franziska_Heine added a project: Wikidata-Sprint-2017-11-07.Nov 7 2017, 2:45 PM
WMDE-leszek mentioned this in T179650: Investigation: Create a proof of concept making wbsetclaim API work with editing statements of forms.Nov 9 2017, 8:27 AM
gerritbot subscribed.Nov 13 2017, 6:53 PM

Change 391057 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add test for wbsetclaim API on a Form and make it pass

https://gerrit.wikimedia.org/r/391057

gerritbot added a project: Patch-For-Review.Nov 13 2017, 6:53 PM
thiemowmde mentioned this in rEWLE6ff447c2be90: Add test for wbsetclaim API on a Form and make it pass.Nov 13 2017, 6:58 PM
thiemowmde mentioned this in rEWLEbaa7ee5dc192: Add test for wbsetclaim API on a Form and make it pass.Nov 14 2017, 7:37 AM
thiemowmde moved this task from Backlog to In Progress on the Wikidata-Sprint-2017-11-07 board.Nov 14 2017, 11:29 AM
WMDE-leszek created subtask T180464: Investigation: If and how form IDs like F1 and L1-F1 should co-exist in the code base.Nov 14 2017, 2:01 PM
WMDE-leszek moved this task from In Progress to Backlog on the Wikidata-Sprint-2017-11-07 board.
WMDE-leszek created subtask T180467: Make it possible to handle sub-entities in the storage layer of Wikibase (days: 1).Nov 14 2017, 2:11 PM
WMDE-leszek created subtask T180469: Make Forms and FormId implement Entity interfaces.Nov 14 2017, 2:14 PM
WMDE-leszek created subtask T180470: Adjust demo data of forms after statements on the form can be saved.Nov 14 2017, 2:18 PM
WMDE-leszek mentioned this in T180471: Create tests for editing statements on Forms.Nov 14 2017, 2:21 PM
WMDE-leszek created subtask T180471: Create tests for editing statements on Forms.
thiemowmde moved this task from Backlog to In Progress on the Wikidata-Sprint-2017-11-07 board.Nov 17 2017, 12:13 PM
WMDE-leszek moved this task from In Progress to Backlog on the Wikidata-Sprint-2017-11-07 board.Nov 20 2017, 11:12 AM
thiemowmde closed subtask T180464: Investigation: If and how form IDs like F1 and L1-F1 should co-exist in the code base as Resolved.Nov 21 2017, 11:10 AM
WMDE-leszek closed subtask T179650: Investigation: Create a proof of concept making wbsetclaim API work with editing statements of forms as Resolved.Nov 21 2017, 1:16 PM
WMDE-leszek added a project: Wikidata-Sprint-2017-11-22.Nov 21 2017, 3:00 PM
Lydia_Pintscher removed a project: Wikidata-Former-Sprint-Board.Nov 23 2017, 1:28 PM
• Jonas renamed this task from persistently addable/editable/removable statements on a Form via the UI (L) to Make UI use wbsetclaim API for Form Statements.Nov 23 2017, 4:05 PM
• Jonas claimed this task.
• Jonas removed projects: Patch-For-Review, Wikidata-Sprint-2017-11-07, Story.
• Jonas updated the task description. (Show Details)
• Jonas moved this task from Backlog to In Progress on the Wikidata-Sprint-2017-11-22 board.
• Jonas removed subscribers: gerritbot, Aklapper, Lydia_Pintscher.
• Jonas renamed this task from Make UI use wbsetclaim API for Form Statements to persistently addable/editable/removable statements on a Form via the UI (L).Nov 23 2017, 4:09 PM
• Jonas removed • Jonas as the assignee of this task.
• Jonas updated the task description. (Show Details)
• Jonas moved this task from In Progress to Backlog on the Wikidata-Sprint-2017-11-22 board.
• Jonas created subtask T181253: Make UI use wbsetclaim API for Form Statements.
• Jonas added subscribers: Lydia_Pintscher, • Jonas.
thiemowmde closed subtask T180469: Make Forms and FormId implement Entity interfaces as Resolved.Nov 23 2017, 4:41 PM
thiemowmde closed subtask T180471: Create tests for editing statements on Forms as Resolved.
Liuxinyu970226 subscribed.Nov 25 2017, 11:24 AM
gerritbot added a comment.Nov 29 2017, 8:44 PM

Change 394138 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Let FormSet::add replace existing Form instead of failing

https://gerrit.wikimedia.org/r/394138

gerritbot added a project: Patch-For-Review.Nov 29 2017, 8:44 PM
thiemowmde mentioned this in rEWLEddce246140ba: Let FormSet::add replace existing Form instead of failing.Nov 29 2017, 8:45 PM
thiemowmde mentioned this in rEWLE6ffff08f77a7: Let FormSet::add replace existing Form instead of failing.Nov 30 2017, 1:14 PM
thiemowmde mentioned this in rEWLE80d7ce8579bf: Let FormSet::add replace existing Form instead of failing.Nov 30 2017, 2:35 PM
WMDE-leszek added a project: Wikidata-Sprint-2017-12-06.Dec 5 2017, 2:18 PM
gerritbot added a comment.Dec 8 2017, 3:13 PM

Change 396401 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Enable skipped SetClaimTest with Forms

https://gerrit.wikimedia.org/r/396401

thiemowmde mentioned this in rEWLEaad15603ff9d: Enable skipped SetClaimTest with Forms.Dec 8 2017, 3:15 PM
thiemowmde mentioned this in rEWLE9adb7d89fe60: Enable skipped SetClaimTest with Forms.Dec 8 2017, 3:57 PM
thiemowmde mentioned this in rEWLE7e11028ea847: Enable skipped SetClaimTest with Forms.Dec 8 2017, 4:31 PM
thiemowmde claimed this task.Dec 11 2017, 11:10 AM
thiemowmde moved this task from Backlog to In Progress on the Wikidata-Sprint-2017-12-06 board.
thiemowmde mentioned this in rEWLEc623f7da3ac4: Enable skipped SetClaimTest with Forms.Dec 11 2017, 11:25 AM
WMDE-leszek moved this task from In Progress to Backlog on the Wikidata-Sprint-2017-12-06 board.Dec 18 2017, 8:59 AM
gerritbot added a comment.Dec 18 2017, 1:38 PM

Change 394136 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Rename Lexeme::addForm to addNewForm

https://gerrit.wikimedia.org/r/394136

thiemowmde mentioned this in rEWLE39bb6c321e3d: Rename Lexeme::addForm to addNewForm.Dec 18 2017, 1:38 PM
gerritbot added a comment.Dec 18 2017, 1:42 PM

Change 398838 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Rename FormSet::add to set

https://gerrit.wikimedia.org/r/398838

thiemowmde mentioned this in rEWLE943085f11de1: Rename FormSet::add to set.Dec 18 2017, 1:44 PM
Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Dec 18 2017, 2:36 PM
thiemowmde closed subtask T180467: Make it possible to handle sub-entities in the storage layer of Wikibase (days: 1) as Resolved.Dec 18 2017, 3:20 PM
WMDE-leszek reopened subtask T180467: Make it possible to handle sub-entities in the storage layer of Wikibase (days: 1) as Open.Dec 18 2017, 3:25 PM
WMDE-leszek closed subtask T180467: Make it possible to handle sub-entities in the storage layer of Wikibase (days: 1) as Resolved.Dec 19 2017, 11:51 AM
WMDE-leszek added a project: Wikidata-Sprint-2017-12-20.Dec 19 2017, 2:26 PM
gerritbot added a comment.Dec 19 2017, 4:24 PM

Change 399214 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Workaround EditFilterMergedContent hook assuming sub-entities have a Content

https://gerrit.wikimedia.org/r/399214

WMDE-leszek mentioned this in rEWLE53a2b88cbce7: Enable skipped SetClaimTest with Forms.Dec 27 2017, 8:57 AM
gerritbot added a comment.Dec 27 2017, 10:09 AM

Change 399214 abandoned by Thiemo Kreuz (WMDE):
Workaround EditFilterMergedContent hook assuming sub-entities have a Content

Reason:
Superseded by I26f9b72.

https://gerrit.wikimedia.org/r/399214

WMDE-leszek mentioned this in rEWLE2a9b5abb0aad: Enable skipped SetClaimTest with Forms.Dec 27 2017, 11:45 AM
gerritbot added a comment.Dec 27 2017, 12:12 PM

Change 396401 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Enable skipped SetClaimTest with Forms

https://gerrit.wikimedia.org/r/396401

WMDE-leszek moved this task from Backlog to Done on the Wikidata-Sprint-2017-12-20 board.Dec 27 2017, 1:31 PM
WMDE-leszek closed this task as Resolved.Jan 2 2018, 2:30 PM
WMDE-leszek closed subtask T181253: Make UI use wbsetclaim API for Form Statements as Resolved.
WMDE-leszek closed subtask T180470: Adjust demo data of forms after statements on the form can be saved as Resolved.
WMDE-leszek removed a project: Patch-For-Review.
Liuxinyu970226 unsubscribed.Jan 5 2018, 11:30 AM
thiemowmde mentioned this in rEWLE6d7d8084a10d: Rename Lexeme::addForm to addNewForm.Jan 10 2018, 5:20 PM
thiemowmde mentioned this in rEWLEfcd584ab6765: Rename Lexeme::addForm to addNewForm.Jan 10 2018, 6:10 PM
thiemowmde mentioned this in rEWLE437eaed47d77: Let FormSet::add replace existing Form instead of failing.Jan 11 2018, 2:52 PM
thiemowmde mentioned this in rEWLE5126c76fab80: Rename FormSet::add to set.
gerritbot added a comment.Apr 11 2018, 11:50 AM

Change 398838 abandoned by Thiemo Kreuz (WMDE):
Rename FormSet::add to set

https://gerrit.wikimedia.org/r/398838

gerritbot added a comment.May 14 2018, 2:06 PM

Change 394136 abandoned by Thiemo Kreuz (WMDE):
Rename Lexeme::addForm to addNewForm

https://gerrit.wikimedia.org/r/394136

WMDE-leszek mentioned this in rEWLE372d75eaf8bf: Update patch set 2.Jun 9 2018, 12:03 PM
thiemowmde mentioned this in rEWLEda85db66b14e: Update patch set 2.Jun 9 2018, 12:03 PM
gerritbot added a comment.Aug 31 2018, 12:02 PM

Change 394138 abandoned by Thiemo Kreuz (WMDE):
Let FormSet::add replace existing Form instead of failing

https://gerrit.wikimedia.org/r/394138

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL