Fix align/layout on Special:GlobalGroupPermissions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MarcoAurelio
	Jul 3 2017, 3:56 PM

Description

Please check this:

GlobalGroupPermissions.png (683×1 px, 58 KB)

Could we please make that the checkbox, text and description be in the same line as it was before? It's very ugly right now and very confusing.

Thanks

Details

	Subject	Repo	Branch	Lines +/-
	Fix layout on Special:GlobalGroupPermissions	mediawiki/extensions/CentralAuth	master	+11 -2

Customize query in gerrit

Event Timeline

MarcoAurelio created this task.Jul 3 2017, 3:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2017, 3:56 PM

My skin is monobook, but I also checked with Vector and it gives me the same ugly layout.

MarcoAurelio added a project: Stewards-and-global-tools.Jul 3 2017, 3:57 PM

MarcoAurelio added a project: Design.Jul 3 2017, 4:09 PM

Ciencia_Al_Poder moved this task from Backlog to Management UI on the MediaWiki-extensions-CentralAuth board.Jul 19 2017, 6:46 PM

MarcoAurelio moved this task from Untriaged to Low priority on the Stewards-and-global-tools board.Jul 26 2017, 2:36 PM

Hi people. This new design is really annoying and unhelpful. Can it be reverted or fixed soonish? Thanks.

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptAug 10 2017, 10:13 PM

Oh, I think I know what's wrong. This isn't on purpose

		return $this->getOutput()->parseInline( User::getRightDescription( $right ) ) . ' ' .
			Html::element( 'code', [], $this->msg( 'parentheses', $right )->text() );

it's adding the <div class="mw-parser-output"> which is breaking the layout.

@Legoktm Couldn't find the commit in rECAU. Was that added for rMW instead? Could it be fixed for CentralAuth? Thanks!

MarcoAurelio moved this task from unsorted/backlog to radar on the User-MarcoAurelio board.Aug 12 2017, 8:59 PM

Change 376490 had a related patch set uploaded (by Melos; owner: Melos):
[mediawiki/extensions/CentralAuth@master] Fix layout on Special:GlobalGroupPermissions

https://gerrit.wikimedia.org/r/376490

gerritbot added a project: Patch-For-Review.Sep 7 2017, 9:32 AM

Hello. Can we please have @Melos's patch above reviewed? The page design is broken and I'm having a hard time figuring out which checkbox pertains to which grant. Thank you.