[wmf.12] Namespace exclusion not saved
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Wargo
	Aug 6 2017, 11:27 AM

Description

When you save filters with Namespace Excluded and navigate away from RC page, and then return to RC - loading saved filters with excluded Namespaces will display results that

Enter recentchanges
Choose namespace(s) to filter
Click exclude button
It should exclude selected namespaces - it works
Now save whole set.
Close the RC page tab. Then navigate to RC page again.
Load saved filter
Notice selected namespaces are not excluded but included. Can't see "not" word on buttons in Active filters and on results it shows only from selected namespaces instead "from all excluding selected".

Details

	Subject	Repo	Branch	Lines +/-
	RCFilters: preserve invert parameter in saved queries	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis
Collaboration-Team-Triage (Collab-Team-This-Quarter)

Event Timeline

Wargo created this task.Aug 6 2017, 11:27 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 6 2017, 11:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Wargo, thanks for this report. But I just saved not:talk and not:user talk filters on en.wikipedia, and it looks like it works fine. Can you please be more specific about what you're doing, and what doesn't work?

And when you enter on Recentchanges page and load saved setting you still have "not" options to them? It saves only namespaces but "not" is not assigned.

@Wargo: In general, a list of steps to reproduce is welcome (including URLs) to avoid misunderstandings and allow reproducing. Thanks :)

Enter recentchanges
Choose namespace(s) to filter
Click exclude button
It should exclude selected namespaces - it works
Now save whole set
Enter to RC again
Load saved filter
Notice selected namespaces are not excluded but included. Can't see "not" word on buttons in Active filters and on results it shows only from selected namespaces instead "from all excluding selected".

Maybe only me?

Thx, @Wargo - Confirmed on enwiki (wmf.12) and betalabs.

Ahh. Thanks Wargo. I see it now. The missing piece was that you have to leave RC page and then come back to it.

• jmatazzoni updated the task description. (Show Details)Aug 7 2017, 5:39 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).Aug 7 2017, 5:42 PM

• jmatazzoni mentioned this in T157642: Graduate New Filters UX out of beta on Recent Changes on ALL wikis.Aug 7 2017, 7:02 PM

SBisson claimed this task.Aug 7 2017, 7:45 PM

SBisson moved this task from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 370526 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] RCFilters: preserve invert parameter in saved queries

https://gerrit.wikimedia.org/r/370526

gerritbot added a project: Patch-For-Review.Aug 7 2017, 7:46 PM

SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Aug 7 2017, 7:58 PM

Mooeypoo moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Aug 15 2017, 6:02 AM

Change 370526 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: preserve invert parameter in saved queries

https://gerrit.wikimedia.org/r/370526

ReleaseTaggerBot added a project: MW-1.30-release-notes.Aug 21 2017, 6:02 PM