Page MenuHomePhabricator
Create Task
Maniphest T178699

PHP 7.1 throws a warning for TranslateToolbox::toolboxAllTranslations(), hence migrate to new hook
Closed, ResolvedPublic
Actions

Description

I have noticed in the logs that the following warning is thrown, (nothing is broken)

PHP Warning: Parameter 1 to TranslateToolbox::toolboxAllTranslations() expected to be a reference, value given in /var/www/html/includes/Hooks.php on line 186

To reproduce

  1. Install MediaWiki
  2. Make sure that you are on PHP 7.1
  3. Install Translate
  4. Check the Error log

This should be migrated to BaseTemplateToolbox.

MediaWiki 1.29.1
PHP 7.1
Latest version of Translate

Details

SubjectRepoBranchLines +/-
Migrate to BaseTemplateToolbox hookmediawiki/extensions/Translatemaster+12 -9
Customize query in gerrit

Event Timeline

MacFan4000 created this task.Oct 20 2017, 4:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2017, 4:48 PM
MacFan4000 moved this task from Unsorted to PHP 7.1 on the [DO NOT USE] NewPHP board.Oct 20 2017, 4:49 PM
MacFan4000 added a subscriber: Nikerabbit.
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Oct 20 2017, 8:39 PM
Nikerabbit added a project: good first task.Oct 20 2017, 8:44 PM

It seems to always be called with a reference, not sure why the warning. In any case it should likely be migrated to BaseTemplateToolbox.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 20 2017, 8:44 PM
MtDu subscribed.Oct 22 2017, 2:07 PM

@Nikerabbit Suitable for GCI?

Nikerabbit added a comment.Oct 22 2017, 4:33 PM

Just removing the & is one character change to get rid of the warning, which would be too easy. I need to check how the new hook works to see if it is not too complicated.

Nikerabbit added a comment.Oct 23 2017, 11:46 AM

I checked, migrating to the new hook should be a nice GCI task.

Aklapper added a project: Google-Code-in-2017.Oct 23 2017, 2:29 PM
Aklapper renamed this task from PHP 7.1 throws a warning for translate to PHP 7.1 throws a warning for TranslateToolbox::toolboxAllTranslations(), hence migrate to new hook.Nov 25 2017, 8:26 PM
Aklapper updated the task description. (Show Details)
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Nov 25 2017, 8:29 PM

Imported as https://codein.withgoogle.com/tasks/5079033899384832/

nikitavbv claimed this task.Nov 28 2017, 6:57 PM
nikitavbv subscribed.

I will work on fixing this

nikitavbv added a comment.Nov 28 2017, 10:30 PM

Unluckily, I have problems with reproducing this issue. I am using PHP 7.1, but I don't get that warning in the log. Does it occur on some specific page / after some action?

gerritbot subscribed.Nov 29 2017, 10:27 AM

Change 394029 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[mediawiki/extensions/Translate@master] Migrate to BaseTemplateToolbox hook

https://gerrit.wikimedia.org/r/394029

gerritbot added a project: Patch-For-Review.Nov 29 2017, 10:27 AM
nikitavbv added a comment.Nov 29 2017, 10:43 AM

I am done with migrating SkinTemplateToolboxEnd hook to BaseTemplateToolbox

gerritbot added a comment.Nov 29 2017, 12:26 PM

Change 394029 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Migrate to BaseTemplateToolbox hook

https://gerrit.wikimedia.org/r/394029

Nikerabbit closed this task as Resolved.Nov 29 2017, 12:31 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Nov 29 2017, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL