Page MenuHomePhabricator
Create Task
Maniphest T179517

Warning: min(): Array must contain at least one element in ApiQueryTranslatorStats
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted in production: Warning: min(): Array must contain at least one element in /srv/mediawiki/php-1.31.0-wmf.5/extensions/ContentTranslation/api/ApiQueryTranslatorStats.php on line 57

Details

SubjectRepoBranchLines +/-
Fix PHP warning for min() methodmediawiki/extensions/ContentTranslationwmf/1.31.0-wmf.6+3 -1
Fix PHP warning for min() methodmediawiki/extensions/ContentTranslationmaster+3 -1
Customize query in gerrit

Event Timeline

• demon created this task.Nov 1 2017, 5:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2017, 5:46 PM
Nikerabbit added a project: Language-2017-Oct-Dec.Nov 2 2017, 9:40 AM
Nikerabbit added subscribers: • Petar.petkovic, Nikerabbit.

@Petar.petkovic I believe this is coming from your patch. Want to have a look at it?

gerritbot subscribed.Nov 2 2017, 11:50 AM

Change 388033 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix PHP warning for min() method

https://gerrit.wikimedia.org/r/388033

gerritbot added a project: Patch-For-Review.Nov 2 2017, 11:50 AM
• Petar.petkovic claimed this task.Nov 2 2017, 11:50 AM
• Petar.petkovic moved this task from Backlog to In Review on the Language-2017-Oct-Dec board.
• demon added a comment.Nov 2 2017, 7:33 PM

Dunno if these two are related or not:

  • Notice: Undefined property: ApiQueryContentTranslation::$user in /srv/mediawiki/php-1.31.0-wmf.6/extensions/ContentTranslation/api/ApiQueryContentTranslation.php on line 120
  • Notice: Undefined variable: translation in /srv/mediawiki/php-1.31.0-wmf.6/extensions/ContentTranslation/api/ApiQueryContentTranslation.php on line 126
• Petar.petkovic added a subscriber: • santhosh.Nov 2 2017, 8:02 PM
In T179517#3730637, @demon wrote:

Dunno if these two are related or not:

  • Notice: Undefined property: ApiQueryContentTranslation::$user in /srv/mediawiki/php-1.31.0-wmf.6/extensions/ContentTranslation/api/ApiQueryContentTranslation.php on line 120
  • Notice: Undefined variable: translation in /srv/mediawiki/php-1.31.0-wmf.6/extensions/ContentTranslation/api/ApiQueryContentTranslation.php on line 126

Those two "Notices" are related to each other and one problem causes both of them to appear, but aren't related to the warning originally reported in the description of this ticket.
Two of those are introduced in this patch. @santhosh, please take a look at this.

• santhosh added a comment.Nov 3 2017, 5:53 AM
In T179517#3730713, @Petar.petkovic wrote:
In T179517#3730637, @demon wrote:

Dunno if these two are related or not:

  • Notice: Undefined property: ApiQueryContentTranslation::$user in /srv/mediawiki/php-1.31.0-wmf.6/extensions/ContentTranslation/api/ApiQueryContentTranslation.php on line 120
  • Notice: Undefined variable: translation in /srv/mediawiki/php-1.31.0-wmf.6/extensions/ContentTranslation/api/ApiQueryContentTranslation.php on line 126

Fixed in https://gerrit.wikimedia.org/r/388388 ApiQueryContentTranslation: Fix php warnings

gerritbot added a comment.Nov 3 2017, 8:18 AM

Change 388033 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix PHP warning for min() method

https://gerrit.wikimedia.org/r/388033

• Petar.petkovic moved this task from In Review to QA on the Language-2017-Oct-Dec board.Nov 3 2017, 8:19 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 3 2017, 9:00 AM
gerritbot added a comment.Nov 3 2017, 3:30 PM

Change 388460 had a related patch set uploaded (by Chad; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@wmf/1.31.0-wmf.6] Fix PHP warning for min() method

https://gerrit.wikimedia.org/r/388460

gerritbot added a comment.Nov 3 2017, 4:00 PM

Change 388460 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@wmf/1.31.0-wmf.6] Fix PHP warning for min() method

https://gerrit.wikimedia.org/r/388460

• demon added a comment.Nov 3 2017, 4:08 PM

Fix for min() is live and looks good! Just waiting on the second one to merge

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)); removed MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 3 2017, 5:01 PM
Arrbee moved this task from Needs Triage to Oct-Dec 2017 on the ContentTranslation board.Nov 8 2017, 11:11 AM
Etonkovidova subscribed.Nov 9 2017, 7:59 PM

Checked in wmf.6 - no issues found.

Etonkovidova closed this task as Resolved.Nov 9 2017, 7:59 PM
Nikerabbit removed a project: Patch-For-Review.Nov 10 2017, 9:44 AM
Nikerabbit moved this task from QA to Done on the Language-2017-Oct-Dec board.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL