This task encompasses the actual work of integrating our app with the new Reading List REST API.
The test server is set up at https://readinglists.wmflabs.org/api/rest_v1/
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Integrate with Reading List service. | apps/android/wikipedia | master | +1 K -134 |
Related Objects
Related Objects
Event Timeline
Comment Actions
@Tgr Question about the reading list service:
The endpoint of /data/lists/changes/since/{date} correctly returns an empty list when there haven't been any changes. However, it also returns an empty list (and no error) when the reading lists haven't been set up for the user. Shouldn't it return an error code of readinglists-db-error-not-set-up?
Comment Actions
Only the write operations check that. I can add it to the rest if you think it's helpful.
Comment Actions
Yeah, at least in this particular case I think it will be useful on our end. This would be consistent with the /data/lists/ endpoint, which does in fact seem to return the error when lists aren't set up (which is also good).
Comment Actions
Change 391048 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Integrate with Reading List service.
Comment Actions
Change 391048 merged by jenkins-bot:
[apps/android/wikipedia@master] Integrate with Reading List service.