Page MenuHomePhabricator
Create Task
Maniphest T180454

Sort out the mess that is the DataTypes extension / library / npm packages in order to kill the build
Closed, ResolvedPublic
Actions

Description

Tracking ticket of sorts to group all sub tickets related to sorting the DataTypes repo / lib / extension / package out while killing the wikidata build.

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Delete forgotten wikibase-data-types.phpmediawiki/extensions/Wikibasemaster+0 -8
Move over files of Data View library (JS part)mediawiki/extensions/Wikibasemaster+350 -67
Remove data-values/data-typesmediawiki/vendormaster+1 -848
Move over code of the Data Types library (PHP part)mediawiki/extensions/Wikibasemaster+429 -37
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAddshoreT173818 [Epic] Kill the Wikidata build step
 ResolvedAddshoreT175026 Remove extensions from the Wikidata build and deploy as a regular extension
 ResolvedAddshoreT175025 Remove the "Wikibase" extension from the build and deploy as a regular extension
 ResolvedAddshoreT180067 Stop using composer class autoloading for "Wikibase" extension
 ResolvedAddshoreT175024 Remove the "WikibaseQuality" extension from the build and deploy as a regular extension
 ResolvedWMDE-leszekT180066 Stop using composer class autoloading for "WikibaseQuality" extension
 ResolvedAddshoreT175022 Remove the "ArticlePlaceholder" extension from the build and deploy as a regular extension
 ResolvedLegoktmT180065 Stop using composer class autoloading for "ArticlePlaceholder" extension
 ResolvedAddshoreT175023 Remove the "WikibaseQualityConstraints" extension from the build and deploy as a regular extension
 ResolvedAddshoreT180064 Stop using composer class autoloading for "WikibaseQualityConstraints" extension
 ResolvedAddshoreT180634 Bring extensions that were in the Wikidata build up to date with the code currently in the build for wmf.8 branch
 ResolvedAddshoreT175021 Remove the "PropertySuggester" extension from the build and deploy as a regular extension
 ResolvedLegoktmT180063 Stop using composer class autoloading for "PropertySuggester" extension
 ResolvedAddshoreT175019 Remove the "WikimediaBadges" extension from the build and deploy as a regular extension
 ResolvedLegoktmT180061 Stop using composer class autoloading for "WikimediaBadges" extension
 ResolvedAddshoreT175018 Remove the "Wikidata.org" extension from the build and deploy as a regular extension
 ResolvedLegoktmT180060 Stop using composer class autoloading for "Wikidata.org" extension
 ResolvedWMDE-leszekT178739 Remove ValueView "extension" from the Wikidata build
 ResolvedAddshoreT180539 wmf.8 still on old Wikidata branch
 ResolvedPRODUCTION ERRORdanielT180605 Argument 1 passed to Wikibase\HistoryEntityAction::__construct() must be an instance of Article, WikiPage given in /srv/mediawiki/php-1.31.0-wmf.8/extensions/Wikidata/extensions/Wikibase/repo/includes/Content/ItemHandler.php on line 118
 InvalidAddshoreT180827 Bring extensions that were in the Wikidata build up to date with the code currently in the build for wmf.10 branch
 ResolvedWMDE-leszekT180454 Sort out the mess that is the DataTypes extension / library / npm packages in order to kill the build
 ResolvedWMDE-leszekT180445 Make pseudo-PHP library data-values/data-types a npm package and include it as a git submodule in Wikibase git repo
 ResolvedWMDE-leszekT180447 Turn pseudo-PHP library data-values/data-types into a npm package
 ResolvedWMDE-leszekT180448 Include wikibase-data-types npm package as a submodule of Wikibase git repo
 InvalidNoneT175020 Remove the "DataTypes" extension from the build and deploy as a regular extension
 InvalidWMDE-leszekT180062 Stop using composer class autoloading for "DataTypes" extension
 ResolvedAddshoreT180449 Add data-values/data-types to mediawiki-vendor
 ResolvedLadsgroupT127292 [Task] Move DataTypes repository from Github to gerrit
 ResolvedAddshoreT180455 Remove DataTypes extension from make-wmf-branch script
 InvalidNoneT180456 Move git repository of data-values/data-types PHP library out of mediawiki/extensions
 InvalidNoneT180459 Update the location of DataTypes i18n on translatewiki.net
 Resolved• demonT180475 Create phabricator mirror of DataTypes github repo used as Wikibase submodule

Event Timeline

Addshore created this task.Nov 14 2017, 12:34 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptNov 14 2017, 12:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore added a subtask: T180448: Include wikibase-data-types npm package as a submodule of Wikibase git repo.Nov 14 2017, 12:34 PM
Addshore added a subtask: T180447: Turn pseudo-PHP library data-values/data-types into a npm package.
Addshore added a subtask: T180445: Make pseudo-PHP library data-values/data-types a npm package and include it as a git submodule in Wikibase git repo.
Addshore added a subtask: T175020: Remove the "DataTypes" extension from the build and deploy as a regular extension.
Addshore added a subtask: T180062: Stop using composer class autoloading for "DataTypes" extension.
Addshore added a subtask: T180449: Add data-values/data-types to mediawiki-vendor.
Addshore added a subtask: T127292: [Task] Move DataTypes repository from Github to gerrit.
Addshore created subtask T180455: Remove DataTypes extension from make-wmf-branch script.Nov 14 2017, 12:37 PM
WMDE-leszek created subtask T180456: Move git repository of data-values/data-types PHP library out of mediawiki/extensions.Nov 14 2017, 12:42 PM
Addshore mentioned this in T175020: Remove the "DataTypes" extension from the build and deploy as a regular extension.Nov 14 2017, 12:43 PM
Addshore closed subtask T175020: Remove the "DataTypes" extension from the build and deploy as a regular extension as Invalid.
WMDE-leszek closed subtask T180062: Stop using composer class autoloading for "DataTypes" extension as Invalid.Nov 14 2017, 12:44 PM
Addshore reassigned this task from Addshore to WMDE-leszek.Nov 14 2017, 12:45 PM
Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.
WMDE-leszek created subtask T180459: Update the location of DataTypes i18n on translatewiki.net.Nov 14 2017, 1:03 PM
Addshore closed subtask T180448: Include wikibase-data-types npm package as a submodule of Wikibase git repo as Resolved.Nov 14 2017, 2:24 PM
Addshore closed subtask T180447: Turn pseudo-PHP library data-values/data-types into a npm package as Resolved.
Addshore closed subtask T180445: Make pseudo-PHP library data-values/data-types a npm package and include it as a git submodule in Wikibase git repo as Resolved.
Addshore created subtask T180475: Create phabricator mirror of DataTypes github repo used as Wikibase submodule.Nov 14 2017, 2:44 PM
Addshore closed subtask T180449: Add data-values/data-types to mediawiki-vendor as Resolved.Nov 14 2017, 2:53 PM
Addshore closed subtask T180475: Create phabricator mirror of DataTypes github repo used as Wikibase submodule as Resolved.Nov 14 2017, 5:36 PM
WMDE-leszek closed subtask T180456: Move git repository of data-values/data-types PHP library out of mediawiki/extensions as Invalid.Nov 17 2017, 7:39 AM
gerritbot subscribed.Dec 5 2017, 12:25 PM

Change 395516 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Move over files of Data View library (JS part)

https://gerrit.wikimedia.org/r/395516

gerritbot added a project: Patch-For-Review.Dec 5 2017, 12:25 PM
gerritbot added a comment.Dec 5 2017, 12:45 PM

Change 395518 had a related patch set (by WMDE-leszek) published:
[mediawiki/vendor@master] Remove data-values/data-types

https://gerrit.wikimedia.org/r/395518

WMDE-leszek added a project: Wikidata-Sprint-2017-12-06.Dec 5 2017, 2:29 PM
WMDE-leszek moved this task from Backlog to Review on the Wikidata-Sprint-2017-12-06 board.
WMDE-leszek closed subtask T180459: Update the location of DataTypes i18n on translatewiki.net as Invalid.Dec 5 2017, 4:56 PM
Addshore mentioned this in T180172: DataTypes should use MediaWiki qunit runner.Dec 6 2017, 9:29 AM
Addshore mentioned this in T100426: [Story] Reorganize DataTypes code on component level.
hashar subscribed.Dec 6 2017, 9:40 AM
gerritbot added a comment.Dec 6 2017, 9:51 AM

Change 395044 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move over code of the Data Types library (PHP part)

https://gerrit.wikimedia.org/r/395044

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 6 2017, 10:00 AM
gerritbot added a comment.Dec 6 2017, 10:04 AM

Change 395516 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move over files of Data View library (JS part)

https://gerrit.wikimedia.org/r/395516

gerritbot added a comment.Dec 6 2017, 10:04 AM

Change 395518 merged by jenkins-bot:
[mediawiki/vendor@master] Remove data-values/data-types

https://gerrit.wikimedia.org/r/395518

thiemowmde removed a project: Patch-For-Review.Dec 7 2017, 4:14 PM
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2017-12-06 board.
Addshore closed this task as Resolved.Dec 8 2017, 10:25 AM

Will close this and leave T180455 hanging around as final cleanup (though not too important)

WMDE-leszek mentioned this in T182566: Make DataTypes repository read-only.Dec 11 2017, 10:43 AM
Addshore moved this task from Watching 👀 to Closing ✔️ on the User-Addshore board.Dec 12 2017, 9:36 AM
Addshore closed subtask T180455: Remove DataTypes extension from make-wmf-branch script as Resolved.Jan 5 2018, 1:20 PM
gerritbot added a comment.Mar 14 2018, 12:31 PM

Change 419407 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Delete forgotten wikibase-data-types.php

https://gerrit.wikimedia.org/r/419407

gerritbot added a project: Patch-For-Review.Mar 14 2018, 12:31 PM
gerritbot added a comment.Mar 14 2018, 1:39 PM

Change 419407 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Delete forgotten wikibase-data-types.php

https://gerrit.wikimedia.org/r/419407

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)); removed MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Mar 14 2018, 2:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL