Page MenuHomePhabricator
Create Task
Maniphest T180467

Make it possible to handle sub-entities in the storage layer of Wikibase (days: 1)
Closed, ResolvedPublic
Actions

Description

Should rely on the HierarchicalEntityId concept, once it has been added to the Wikibase Data Model.

The current draft at https://gerrit.wikimedia.org/r/394070 allows extensions to decorate both the EntityStore and the EntityRevisionLookup with a thin layer that knows about a specific type of "sub-entities" (in this case: Forms), and forwards calls appropriately. This decoration layer lives in the Lexeme extension, and uses Lexeme vocabulary. "Sub-entities" or "hierarchies" are never mentioned in this code.

As a consequence, the concept of "sub-entities" will (for now) exclusively live in the Lexeme code base.

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Add tests for invalid callbacks to TypeDispatchingEntity… classesmediawiki/extensions/Wikibasemaster+55 -0
Infrastructure for hierarchicaly adressable entitiesmediawiki/extensions/Wikibasemaster+716 -1
Allow extensions to have entity-type-specific EntityStore/EntityRevisionLookupmediawiki/extensions/Wikibasemaster+999 -3
Add EntityStore/EntityRevisionLookup specific for Formsmediawiki/extensions/WikibaseLexememaster+953 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek created this task.Nov 14 2017, 2:11 PM
WMDE-leszek added a project: Wikidata-Sprint-2017-11-22.Nov 21 2017, 2:59 PM
thiemowmde added a project: User-thiemowmde.Nov 22 2017, 3:40 PM
thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2017-11-22 board.Nov 24 2017, 11:05 AM
gerritbot subscribed.Nov 24 2017, 11:06 AM

Change 378786 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Infrastructure for hierarchicaly adressable entities

https://gerrit.wikimedia.org/r/378786

gerritbot added a project: Patch-For-Review.Nov 24 2017, 11:06 AM
thiemowmde moved this task from Incoming to TechDebt on the User-thiemowmde board.Nov 24 2017, 11:22 AM
thiemowmde claimed this task.Nov 28 2017, 1:13 PM
Ladsgroup moved this task from Review to In Progress on the Wikidata-Sprint-2017-11-22 board.Nov 29 2017, 11:02 AM
gerritbot added a comment.Nov 29 2017, 3:41 PM

Change 394070 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Allow extensions to decorate EntityStore and EntityRevisionLookup

https://gerrit.wikimedia.org/r/394070

gerritbot added a comment.Nov 29 2017, 3:44 PM

Change 394072 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Decorate EntityStore and EntityRevisionLookup to support Forms

https://gerrit.wikimedia.org/r/394072

thiemowmde mentioned this in rEWLEf8619b898551: Decorate EntityStore and EntityRevisionLookup to support Forms.Nov 29 2017, 3:46 PM
thiemowmde mentioned this in rEWLEf396c4030364: Decorate EntityStore and EntityRevisionLookup to support Forms.Nov 29 2017, 3:48 PM
thiemowmde mentioned this in rEWLEff289500b98b: Decorate EntityStore and EntityRevisionLookup to support Forms.Nov 29 2017, 4:45 PM
gerritbot added a comment.Nov 29 2017, 8:44 PM

Change 394136 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Rename Lexeme::addForm to addNewForm

https://gerrit.wikimedia.org/r/394136

thiemowmde mentioned this in rEWLE196a81620fd7: Rename Lexeme::addForm to addNewForm.Nov 29 2017, 8:45 PM
thiemowmde moved this task from In Progress to Review on the Wikidata-Sprint-2017-11-22 board.Nov 30 2017, 6:54 PM
thiemowmde created subtask T181745: [Task] Make FormDiffer/FormPatcher implement EntityDifferStrategy/EntityPatcherStrategy.Nov 30 2017, 7:11 PM
thiemowmde created subtask T181746: [Task] Make ChangeFormDiffOp extend EntityDiff.Nov 30 2017, 7:18 PM
thiemowmde removed a subtask: T181746: [Task] Make ChangeFormDiffOp extend EntityDiff.
thiemowmde updated the task description. (Show Details)Nov 30 2017, 7:24 PM
WMDE-leszek removed a subtask: T181745: [Task] Make FormDiffer/FormPatcher implement EntityDifferStrategy/EntityPatcherStrategy.Dec 5 2017, 1:58 PM
WMDE-leszek mentioned this in T182097: Investigation: Whether it is better to skip permission checks for forms.Dec 5 2017, 2:12 PM
WMDE-leszek created subtask T182097: Investigation: Whether it is better to skip permission checks for forms.
WMDE-leszek added a project: Wikidata-Sprint-2017-12-06.Dec 5 2017, 2:16 PM
WMDE-leszek moved this task from Backlog to Review on the Wikidata-Sprint-2017-12-06 board.
Lucas_Werkmeister_WMDE moved this task from Review to In Progress on the Wikidata-Sprint-2017-11-22 board.Dec 5 2017, 2:18 PM
WMDE-leszek moved this task from Review to In Progress on the Wikidata-Sprint-2017-12-06 board.Dec 5 2017, 2:20 PM
thiemowmde mentioned this in rEWLE6568ad305757: Decorate EntityStore and EntityRevisionLookup to support Forms.Dec 6 2017, 4:43 PM
thiemowmde mentioned this in rEWLE08b458f5b3df: Add EntityStore/EntityRevisionLookup specific for Forms.Dec 6 2017, 5:33 PM
thiemowmde mentioned this in rEWLE11d10348db14: Add EntityStore/EntityRevisionLookup specific for Forms.Dec 8 2017, 3:05 PM
thiemowmde mentioned this in rEWLEc68f1d98bd88: Add EntityStore/EntityRevisionLookup specific for Forms.Dec 8 2017, 3:10 PM
thiemowmde moved this task from In Progress to Review on the Wikidata-Sprint-2017-12-06 board.Dec 8 2017, 3:56 PM
thiemowmde closed subtask T182097: Investigation: Whether it is better to skip permission checks for forms as Resolved.Dec 8 2017, 4:01 PM
thiemowmde mentioned this in rEWLE8c429d5b572c: Add EntityStore/EntityRevisionLookup specific for Forms.Dec 8 2017, 4:31 PM
thiemowmde mentioned this in rEWLEd122965a989f: Add EntityStore/EntityRevisionLookup specific for Forms.Dec 11 2017, 5:32 PM
thiemowmde mentioned this in rEWLEc9e8acabaea4: Add EntityStore/EntityRevisionLookup specific for Forms.Dec 12 2017, 4:34 PM
thiemowmde mentioned this in rEWLE4af8062e5f9e: Add EntityStore/EntityRevisionLookup specific for Forms.Dec 13 2017, 4:36 PM
gerritbot added a comment.Dec 15 2017, 11:36 AM

Change 398443 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Add tests for invalid callbacks to TypeDispatchingEntity… classes

https://gerrit.wikimedia.org/r/398443

WMDE-leszek mentioned this in rEWLE11d332cb7170: Add EntityStore/EntityRevisionLookup specific for Forms.Dec 15 2017, 11:42 AM
gerritbot added a comment.Dec 18 2017, 9:11 AM

Change 394070 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Allow extensions to have entity-type-specific EntityStore/EntityRevisionLookup

https://gerrit.wikimedia.org/r/394070

gerritbot added a comment.Dec 18 2017, 9:11 AM

Change 394072 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add EntityStore/EntityRevisionLookup specific for Forms

https://gerrit.wikimedia.org/r/394072

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 18 2017, 10:00 AM
WMDE-leszek renamed this task from Make it possible to handle sub-entities in the storage layer of Wikibase to Make it possible to handle sub-entities in the storage layer of Wikibase (days: 1).Dec 18 2017, 11:19 AM
gerritbot added a comment.Dec 18 2017, 1:35 PM

Change 378786 abandoned by Thiemo Kreuz (WMDE):
Infrastructure for hierarchicaly adressable entities

Reason:
Replaced by I8466121.

https://gerrit.wikimedia.org/r/378786

thiemowmde updated the task description. (Show Details)Dec 18 2017, 1:37 PM
gerritbot added a comment.Dec 18 2017, 1:47 PM

Change 398443 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add tests for invalid callbacks to TypeDispatchingEntity… classes

https://gerrit.wikimedia.org/r/398443

gerritbot added a comment.Dec 18 2017, 2:14 PM

Change 398844 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Deserialize form-level statement data

https://gerrit.wikimedia.org/r/398844

WMDE-leszek mentioned this in rEWLE99c71177daab: Deserialize form-level statement data.Dec 18 2017, 2:15 PM
WMDE-leszek mentioned this in rEWLEe3451278404f: Deserialize form-level statement data.Dec 18 2017, 2:22 PM
WMDE-leszek mentioned this in rEWLEc95e3e2d3b08: Deserialize form-level statement data.Dec 18 2017, 2:31 PM
WMDE-leszek mentioned this in rEWLE819776c3e1e1: Deserialize form-level statement data.Dec 18 2017, 2:55 PM
thiemowmde closed this task as Resolved.Dec 18 2017, 3:20 PM
thiemowmde removed projects: Patch-For-Review, User-thiemowmde.
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2017-12-06 board.
WMDE-leszek reopened this task as Open.Dec 18 2017, 3:25 PM

Let's close it on tomorrow's stand up!

WMDE-leszek mentioned this in rEWLE8bdcba642837: Deserialize form-level statement data.Dec 18 2017, 4:39 PM
WMDE-leszek added a comment.Dec 19 2017, 8:21 AM

Isn't https://gerrit.wikimedia.org/r/#/c/398844/ also part of this task?

WMDE-leszek mentioned this in rEWLE8e24e75a8da1: Deserialize form-level statement data.Dec 19 2017, 8:24 AM
thiemowmde added a comment.Dec 19 2017, 8:29 AM

This ticket is about structural support in the Wikibase.git code base, but https://gerrit.wikimedia.org/r/398844 is about the (previously incomplete) deserialization of forms in the lexeme code base. Sounds like two entirely separate concepts to me.

WMDE-leszek added a comment.Dec 19 2017, 8:30 AM

right

WMDE-leszek closed this task as Resolved.Dec 19 2017, 11:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL