Currently, the PRIMARY KEY of the wbqc_constraints table (found on wikis with the WikibaseQualityConstraints extension installed: wikidatawiki and testwikidatawiki) is the constraint_guid, which is a Wikibase statement ID: a forty-something character string like P580$F2A0326E-4245-4D26-A63F-DD700B6B7DDD. @Ladsgroup has kindly informed me that this is not ideal :) if we want to join the table against anything else (which we will want to do for T180582 – see this comment for details: feedback is welcome there too!), we should instead have an auto-incrementing integer as the primary key. (And then I assume there should be an index on the constraint_guid, just like we currently have one on the pid.)
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T244043 suggestions and possible decisions from the 2020 report on Property constraints | |||
| Open | None | T192565 Find constraint violations | |||
| Open | Feature | None | T284983 mark Wikidata property constraints as "top-down" (not bottom-up) | ||
| Open | None | T180582 List of all constraint violations | |||
| Resolved | Lucas_Werkmeister_WMDE | T180834 Add numeric primary key to wbqc_constraints table | |||
| Resolved | • Marostegui | T189101 Deploy schema change for adding numeric primary key to wbqc_constraints table |
Event Timeline
Comment Actions
Change 392458 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add constraint_id column to wbqc_constraints table
Comment Actions
Change 392458 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add constraint_id column to wbqc_constraints table
Comment Actions
Change 416924 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix path to SQL script
Comment Actions
Change 416924 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix path to SQL script
Comment Actions
Done except for applying the schema change in production, for which we have a separate task.
Comment Actions
Change 456607 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Make index on constraint_guid unique
Comment Actions
Change 456607 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Make index on constraint_guid unique