Page MenuHomePhabricator
Create Task
Maniphest T181063

'Reply' button is enabled even if nothing has been typed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Conversely the 'Add topic' button is only enabled when a subject and body has been entered

Details

SubjectRepoBranchLines +/-
Disable 'reply' button until something typedmediawiki/extensions/Flowmaster+16 -4
Customize query in gerrit

Event Timeline

Esanders created this task.Nov 21 2017, 4:13 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 21 2017, 4:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Nov 21 2017, 4:31 PM

Change 392672 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Disable 'reply' button until something typed

https://gerrit.wikimedia.org/r/392672

gerritbot added a project: Patch-For-Review.Nov 21 2017, 4:31 PM
gerritbot added a comment.Nov 21 2017, 4:47 PM

Change 392672 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Disable 'reply' button until something typed

https://gerrit.wikimedia.org/r/392672

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 21 2017, 5:00 PM
Jdforrester-WMF assigned this task to Esanders.Nov 21 2017, 8:53 PM
Jdforrester-WMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Patch-For-Review, Collaboration-Team-Triage.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Etonkovidova subscribed.Nov 22 2017, 12:10 AM

Checked the fix in betalabs - 'Reply' button is disabled unless something is typed for a reply.

@Esanders Should it be the same behavior for editing? Unless something is typed, 'Edit title', 'Update summary', 'Save description' , and 'Save changes' should not be active?

Etonkovidova closed this task as Resolved.Nov 22 2017, 12:10 AM
Trizek-WMF added a project: User-notice-collaboration.Nov 22 2017, 2:23 PM
Trizek-WMF moved this task from To Triage to Announce in next Collaboration Newsletter on the User-notice-collaboration board.Dec 14 2017, 3:03 PM
Trizek-WMF moved this task from Announce in next Collaboration Newsletter to In current Collaboration Newsletter draft on the User-notice-collaboration board.Jan 11 2018, 3:17 PM
Trizek-WMF moved this task from In current Collaboration Newsletter draft to Announced in Collaboration Newsletter on the User-notice-collaboration board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL