Page MenuHomePhabricator
Create Task
Maniphest T181314

Post-nominal letters are not properly removed in link previews
Closed, ResolvedPublic
Actions

Description

Post-nominal letters are not properly removed in link previews. Commas surrounding the post-nominal letters are left.

Example: page – link preview

Example 2 (with "post-nominals" template): page – link preview

Example 3 (with two commas): page – link preview

Please fix this by setting Hovercards to remove any commas surrounding post-nominal letters.

Related Objects

Event Timeline

SUM1 created this task.Nov 24 2017, 9:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 24 2017, 9:39 PM
SUM1 updated the task description. (Show Details)Nov 24 2017, 9:39 PM
SUM1 added a project: TextExtracts.
Jdlrobson mentioned this in T113094: [EPIC] The Page Summary API needs to provide useful content for the majority of articles.Nov 27 2017, 6:00 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking), Page-Previews; removed TextExtracts.
Jdlrobson subscribed.

We're in the process of moving this code to a new summary service which does not have this problem in T113094. Thanks for reporting this! It helps to have examples where the current summaries are broken!

• Mholloway subscribed.Nov 27 2017, 6:02 PM
Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Feb 7 2018, 5:51 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Tracking).Feb 22 2018, 10:10 PM
Jdlrobson added a subscriber: ABorbaWMF.

We should verify this is fixed. @ABorbaWMF can you help?

Jdlrobson assigned this task to ABorbaWMF.Feb 22 2018, 10:11 PM
Jdlrobson moved this task from Incoming to QA Tasks / Needs Reproduction on the Web-Team-Backlog board.Feb 22 2018, 10:20 PM
ABorbaWMF closed this task as Resolved.Feb 23 2018, 4:26 AM

Looks good to me

Screen Shot 2018-02-22 at 8.22.51 PM.png (1×2 px, 2 MB)

Screen Shot 2018-02-22 at 2.59.48 PM.png (1×2 px, 2 MB)

Screen Shot 2018-02-22 at 2.59.17 PM.png (1×2 px, 2 MB)

• Phabricator_maintenance moved this task from QA Tasks / Needs Reproduction to 2017-18 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:42 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL