Page MenuHomePhabricator
Create Task
Maniphest T182636

[betalabs] Fatal exception when clicking on deleted topics in View history (Flow\Model\AbstractRevision::getRecentChange)
Closed, ResolvedPublic
Actions

Description

Found when checking T180607: Nuke does not list hidden Flow topics.

  1. User A created three topics on SD board.
  2. User B hides those three topics.
  3. User Administrator deletes those three hidden topics via Special:Nuke .
  4. User Administrator checks 'View history' on the SD board and clicks on the cross-out link, see the screenshot below.

Screen Shot 2017-12-11 at 2.24.48 PM.png (243×1 px, 82 KB)

<span class="mw-changeslist-date history-deleted"><a href="https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:U3lv6guxmjfr7gun&amp;topic_revId=u3lvlowjils63kg9&amp;action=single-view" title="topic revision">21:51, 11 December 2017</a></span>

After the click, the page loads:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:U3lv6guxmjfr7gun&topic_revId=u3lvlowjils63kg9&action=single-view

The following error is displayed:

[Wi8BIgpEE4AAAAN19mUAAAAE] 2017-12-11 22:05:23: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Related Objects

Event Timeline

Etonkovidova created this task.Dec 11 2017, 10:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2017, 10:35 PM
Etonkovidova added a comment.Dec 12 2017, 8:57 PM

The same type of error - from https://logstash-beta.wmflabs.org

[WjBAxApEE4AAAGjZ72sAAAAB] 2017-12-12 20:49:08: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"
[WjBAxApEE4AAAGjZ72sAAAAB] /w/index.php?title=Topic:U3lv6tfk22npdczz&topic_revId=u3lvimxzcxwnsw0f&action=single-view   Wikimedia\Rdbms\DBQueryError from line 1179 of /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
exception.message	       	A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
Query: SELECT  rc_id,rc_timestamp,rc_user,rc_user_text,rc_namespace,rc_title,rc_minor,rc_bot,rc_new,rc_cur_id,rc_this_oldid,rc_last_oldid,rc_type,rc_source,rc_patrolled,rc_ip,rc_old_len,rc_new_len,rc_deleted,rc_logid,rc_log_type,rc_log_action,rc_params,COALESCE( comment_rc_comment.comment_text, rc_comment ) AS `rc_comment_text`,comment_rc_comment.comment_data AS `rc_comment_data`,comment_rc_comment.comment_id AS `rc_comment_cid`  FROM `recentchanges` LEFT JOIN `comment` `comment_rc_comment` ON ((comment_rc_comment.comment_id = rc_comment_id)) FORCE INDEX (rc_timestamp)  WHERE rc_title = 'U3lv6tfk22npdczz' AND rc_timestamp = '20171211215014' AND rc_namespace = '2600'  
Function: Flow\Model\AbstractRevision::getRecentChange
Error: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'FORCE INDEX (rc_timestamp)  WHERE rc_title = 'U3lv6tfk22npdczz' AND rc_timestamp' at line 1 (10.68.18.35:3306)
t  exception.trace	       	#0 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(991): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#1 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1374): Wikimedia\Rdbms\Database->query(string, string)
#2 /srv/mediawiki/php-master/extensions/Flow/includes/Model/AbstractRevision.php(861): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#3 /srv/mediawiki/php-master/extensions/Flow/includes/Formatter/RevisionViewFormatter.php(133): Flow\Model\AbstractRevision->getRecentChange()
#4 /srv/mediawiki/php-master/extensions/Flow/includes/Formatter/RevisionViewFormatter.php(44): Flow\Formatter\RevisionViewFormatter->buildLinks(Flow\Formatter\FormatterRow, Flow\View)
#5 /srv/mediawiki/php-master/extensions/Flow/includes/Block/Topic.php(609): Flow\Formatter\RevisionViewFormatter->formatApi(Flow\Formatter\FormatterRow, Flow\View)
#6 /srv/mediawiki/php-master/extensions/Flow/includes/Block/Topic.php(511): Flow\Block\TopicBlock->renderSingleViewApi(string)
#7 /srv/mediawiki/php-master/extensions/Flow/includes/View.php(190): Flow\Block\TopicBlock->renderApi(array)
#8 /srv/mediawiki/php-master/extensions/Flow/includes/View.php(67): Flow\View->buildApiResponse(Flow\WorkflowLoader, array, string, array)
#9 /srv/mediawiki/php-master/extensions/Flow/includes/Actions/Action.php(112): Flow\View->show(Flow\WorkflowLoader, string)
#10 /srv/mediawiki/php-master/extensions/Flow/includes/Actions/Action.php(50): Flow\Actions\FlowAction->showForAction(string)
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(499): Flow\Actions\FlowAction->show()
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(293): MediaWiki->performAction(Article, Title)
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(851): MediaWiki->performRequest()
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(523): MediaWiki->main()
#15 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#16 /srv/mediawiki/w/index.php(3): include(string)
#17 {main}
  exception_id	       	WjBAxApEE4AAAGjZ72sAAAAB
  exception_url	       	/w/index.php?title=Topic:U3lv6tfk22npdczz&topic_revId=u3lvimxzcxwnsw0f&action=single-view
Aklapper renamed this task from [betalabs] [Wi8BIgpEE4AAAAN19mUAAAAE] Fatal exception of type "Wikimedia\Rdbms\DBQueryError" when clicking on deleted topics in View history to [betalabs] Fatal exception when clicking on deleted topics in View history (Flow\Model\AbstractRevision::getRecentChange).Dec 13 2017, 10:00 AM
Aklapper added a project: StructuredDiscussions.
• jmatazzoni triaged this task as High priority.Jan 2 2018, 8:13 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
SBisson subscribed.Jan 5 2018, 8:58 PM

tl;dr I was not able to reproduce this issue locally or in production. ( @Etonkovidova Please let me know if you can )

Viewing any specific recent[1] Flow revision in betalabs produces this error, no need to hide and Nuke.

It appears to be cause by Flow/includes/Model/AbstractRevision.php:850 ($options = [ 'USE INDEX' => 'rc_timestamp' ];) which contributes to the following SQL

SELECT rc_id,rc_timestamp,rc_user,rc_user_text,rc_namespace,rc_title,rc_minor,rc_bot,rc_new,rc_cur_id,rc_this_oldid,rc_last_oldid,rc_type,rc_source,rc_patrolled,rc_ip,rc_old_len,rc_new_len,rc_deleted,rc_logid,rc_log_type,rc_log_action,rc_params,COALESCE( comment_rc_comment.comment_text, rc_comment ) AS `rc_comment_text`,comment_rc_comment.comment_data AS `rc_comment_data`,comment_rc_comment.comment_id AS `rc_comment_cid`  
FROM `recentchanges` LEFT JOIN `comment` `comment_rc_comment` ON ((comment_rc_comment.comment_id = rc_comment_id)) 
FORCE INDEX (rc_timestamp)  
WHERE rc_title = 'U55be9hj5vbrllov' AND rc_timestamp = '20180105191040' AND rc_namespace = '2600';

It works when I remove FORCE INDEX (rc_timestamp)

[1] Viewing a revision that is older than the recent changes window works because it doesn't enter that code path.

Etonkovidova added a comment.Jan 8 2018, 8:51 PM

@SBisson - regarding

Viewing any specific recent[1] Flow revision in betalabs produces this error, no need to hide and Nuke.

Interesting - when I am trying to view any change on https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:ET8&action=history** after Mass delete **- I see the error

Screen Shot 2018-01-08 at 12.44.03 PM.png (657×1 px, 513 KB)

And I do not have Administrator rights to Delete topics (or Mass delete) in production - only to Hide which seems to work without errors.

SBisson mentioned this in T186077: 'undo' action on SD boards - Fatal exception of type "Wikimedia\Rdbms\DBQueryError".Jan 31 2018, 11:31 AM
SBisson moved this task from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Feb 8 2018, 10:44 AM

I believe this was fixed by the patch for T186077: 'undo' action on SD boards - Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Etonkovidova added a comment.Feb 10 2018, 1:16 AM

Yes, the issue is fixed with the patch in T186077: 'undo' action on SD boards - Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Etonkovidova closed this task as Resolved.Feb 10 2018, 1:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL