Page MenuHomePhabricator
Create Task
Maniphest T184070

Add "This page requires JavaScript" notes to special pages in the Translate extension
Closed, ResolvedPublic
Actions

Description

This task is about MediaWiki's Translate extension.

If you go to Special:Translate after disabling JavaScript in your browser, you get a clear message:

image.png (234×1 px, 35 KB)

When you go to Special:AggregateGroups, Special:ManageTranslatorSandbox, Special:PageMigration, Special:PagePreparation, you don't see such an error message even though the pages require JavaScript to function.

dc1367ef78ddcdf201dab9d8e6634f99216c6e17 has an example how to do it. Basically you need to add such HTML element and the CSS to the appropriate CSS/LESS file. The i18n (internationalization) message can be reused.

Bonus points for not-showing any broken-functionality on this pages when JavaScript is not enable. On Special:AggregateGroups the listing should remain, but without all those boxes that are used for editing.

Details

SubjectRepoBranchLines +/-
Add "This page requires JavaScript" notes to special pagesmediawiki/extensions/Translatemaster+93 -7
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Jan 3 2018, 2:09 PM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptJan 3 2018, 2:09 PM
Aklapper renamed this task from Add "This page requires JavaScript" notes to Translate's special pages to Add "This page requires JavaScript" notes to special pages in the Translate extension.Jan 3 2018, 4:21 PM
Aklapper updated the task description. (Show Details)
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.

Published as https://codein.withgoogle.com/tasks/6676727751245824/

eflyjason claimed this task.Jan 4 2018, 11:10 AM
eflyjason mentioned this in T178484: Remove or regenerate PNG files for Translate.
eflyjason subscribed.
gerritbot subscribed.Jan 4 2018, 12:54 PM

Change 402037 had a related patch set uploaded (by Eflyjason; owner: Eflyjason):
[mediawiki/extensions/Translate@master] Add "This page requires JavaScript" notes to special pages

https://gerrit.wikimedia.org/r/402037

gerritbot added a project: Patch-For-Review.Jan 4 2018, 12:54 PM
gerritbot added a comment.Jan 5 2018, 10:34 AM

Change 402037 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add "This page requires JavaScript" notes to special pages

https://gerrit.wikimedia.org/r/402037

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 5 2018, 11:00 AM
xSavitar moved this task from Backlog to Doing on the good first task board.Jan 26 2018, 4:21 PM
Kizule closed this task as Resolved.Jan 28 2018, 7:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL