RevisionStore.php: comment must not be NULL!
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

[{exception_id}] {exception_url} MediaWiki\Storage\IncompleteRevisionException from line 262 of /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php: comment must not be NULL!

Logstash: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.01.11/mediawiki/?id=AWDip66ohTduSC7pD0se

#0 /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php(365): MediaWiki\Storage\RevisionStore->failOnNull(NULL, string)
#1 /srv/mediawiki/php-1.31.0-wmf.16/includes/Revision.php(1024): MediaWiki\Storage\RevisionStore->insertRevisionOn(MediaWiki\Storage\MutableRevisionRecord, Wikimedia\Rdbms\DatabaseMysqli)
#2 /srv/mediawiki/php-1.31.0-wmf.16/includes/page/WikiPage.php(1765): Revision->insertOn(Wikimedia\Rdbms\DatabaseMysqli)
#3 /srv/mediawiki/php-1.31.0-wmf.16/includes/page/WikiPage.php(1668): WikiPage->doModify(WikitextContent, integer, User, NULL, array)
#4 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Flow/includes/Import/OptInController.php(242): WikiPage->doEditContent(WikitextContent, NULL, integer, boolean, User)
#5 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Flow/includes/Import/OptInController.php(560): Flow\Import\OptInController->createRevision(Title, string, NULL)
#6 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Flow/includes/Import/OptInController.php(579): Flow\Import\OptInController->editWikitextContent(Title, NULL, Closure$Flow\Import\OptInController::addCurrentTemplate;3395, string)
#7 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Flow/includes/Import/OptInController.php(111): Flow\Import\OptInController->addCurrentTemplate(Title, Title)
#8 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Flow/includes/Import/OptInUpdate.php(50): Flow\Import\OptInController->disable(Title)
#9 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/DeferredUpdates.php(259): Flow\Import\OptInUpdate->doUpdate()
#10 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/DeferredUpdates.php(210): DeferredUpdates::runUpdate(Flow\Import\OptInUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#11 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::execute(array, string, integer)
#12 /srv/mediawiki/php-1.31.0-wmf.16/includes/MediaWiki.php(900): DeferredUpdates::doUpdates(string)
#13 /srv/mediawiki/php-1.31.0-wmf.16/includes/MediaWiki.php(720): MediaWiki->restInPeace(string, boolean)
#14 [internal function]: Closure$MediaWiki::doPostOutputShutdown()
#15 {main}

Details

	Subject	Repo	Branch	Lines +/-
	Fix IncompleteRevisionException comment must not be NULL!	mediawiki/extensions/Flow	wmf/1.31.0-wmf.16	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk"

Event Timeline

Addshore created this task.Jan 11 2018, 9:58 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 11 2018, 9:58 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Addshore renamed this task from FLow - MediaWiki\Storage\IncompleteRevisionException from line 262 of /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php: comment must not be NULL! to Flow - MediaWiki\Storage\IncompleteRevisionException from line 262 of /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php: comment must not be NULL!.Jan 11 2018, 9:58 AM

I believe this has been fixed in https://gerrit.wikimedia.org/r/#/c/403082/

daniel moved this task from Inbox to Done on the Multi-Content-Revisions board.Jan 11 2018, 1:02 PM

So, it looks like this has been fixed on master, but I will backport the 1 line fix to the .16 branch

Addshore claimed this task.Jan 11 2018, 3:02 PM

Addshore moved this task from Done to Next on the Multi-Content-Revisions board.

Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 11 2018, 3:02 PM

Change 403668 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Flow@wmf/1.31.0-wmf.16] Fix IncompleteRevisionException comment must not be NULL!

https://gerrit.wikimedia.org/r/403668

gerritbot added a project: Patch-For-Review.Jan 11 2018, 3:04 PM

Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.Jan 11 2018, 3:05 PM

Change 403668 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.31.0-wmf.16] Fix IncompleteRevisionException comment must not be NULL!

https://gerrit.wikimedia.org/r/403668

Addshore closed this task as Resolved.Jan 12 2018, 11:58 AM

Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.

SBisson mentioned this in T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk".Jan 12 2018, 1:28 PM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 13 2018, 7:22 PM

CCicalese_WMF moved this task from Next to Done on the Multi-Content-Revisions board.May 10 2018, 4:45 PM

CCicalese_WMF moved this task from Done to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 10 2018, 4:48 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.

CCicalese_WMF moved this task from Backlog to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 10 2018, 5:06 PM

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper raised the priority of this task from Lowest to Needs Triage.Jun 15 2018, 12:44 PM

Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.

Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.

Aklapper assigned this task to Addshore.Jun 15 2018, 12:47 PM

CCicalese_WMF removed a project: Patch-For-Review.Jul 10 2018, 3:26 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 10 2018, 3:26 AM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM

Flow - MediaWiki\Storage\IncompleteRevisionException from line 262 of /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php: comment must not be NULL!Closed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

Flow - MediaWiki\Storage\IncompleteRevisionException from line 262 of /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php: comment must not be NULL!
Closed, ResolvedPublicPRODUCTION ERROR
Actions