Invisible text in new wikitext editor after large paste
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

open https://hu.wikipedia.org/w/index.php?title=Sablon:Harry_Potter&action=edit with a classic editor, copypaste contents
open it with the new wikitext editor, delete all text
paste in the text (Ctrl-V or Ctrl-Shift-V, does not matter)

Most of the text will be invisible. It can be selected, and reappears as soon as the text is changed.

Seen in Chrome 63.0.3239.132, Ubuntu 16.04.

Details

	Subject	Repo	Branch	Lines +/-
	VE: Use different approach for transparent text issue	mediawiki/extensions/CodeMirror	master	+17 -13
	Defer update of CM surface to avoid invisible text	mediawiki/extensions/CodeMirror	master	+13 -10

Customize query in gerrit

Related Objects

Mentioned In: T171616: Font size changes, and then the editor crashes
T188473: [Regression pre-wmf.23] Weird wikitext formatting observed while editing with NWE when syntax highlighting is on
T188069: Text on category page is invisible when syntax highlighting is enabled
T188186: New wikitext editor should not display uneditable page content
Mentioned Here: T171616: Font size changes, and then the editor crashes

Event Timeline

Tgr created this task.Jan 18 2018, 8:14 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 18 2018, 8:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I can't reproduce this. Do you have syntax highlighting enabled? Any exceptions in the console?

Yeah, sorry, I forgot to mention I have syntax highlight on (and it doesn't happen without that). I tried to reproduce this with another account with the same beta features enabled but couldn't - so maybe some gadget? I don't have anything obviously edit area related, though.

No exceptions. The whole thing feels more like a browser error than a VE error: the text is present (the DOM nodes are there in developer toolbar) but invisible, there is no obvious reason for it to be invisible (the visible and invisible rows have the same structure and attributes), and the behavior is very erratic (for example if I have the developer toolbar open in split-window mode it does not happen).

NWE+SyntaxHighlight deliberately uses invisible text so that work is done in the VE surface, but displayed in the syntax highlighted surface. If you have invisible text that suggests the syntax highlighted surface isn't getting updated.

I've seen the same thing, but could not reproduce. Same setup, but I was probably using Firefox as that is my usual browser unless I must check something in an alternate browser.

I had so much problem with SyntaxHighlight I turned it off. Also SH does not work with spell checkers and LanguageTools, which makes it very awkward.

This sounds a lot like T171616 to me! There it has nothing to do with syntax highlighting, though. In any case I can still reproduce my problems, although I fortunately did not have another crash.

Tgr mentioned this in T188186: New wikitext editor should not display uneditable page content.Feb 24 2018, 8:35 PM

Esanders renamed this task from Invisible text in new wikitext editor to Invisible text in new wikitext editor after large paste.Feb 25 2018, 5:54 PM

Esanders claimed this task.Feb 25 2018, 6:05 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Change 414512 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] Defer update of CM surface to avoid invisible text

https://gerrit.wikimedia.org/r/414512

gerritbot added a project: Patch-For-Review.Feb 25 2018, 6:06 PM

Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.Feb 25 2018, 6:09 PM

Jdforrester-WMF moved this task from In progress to Product owner review on the VisualEditor (Current work) board.Feb 25 2018, 8:56 PM

Change 414512 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Defer update of CM surface to avoid invisible text

https://gerrit.wikimedia.org/r/414512

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 25 2018, 9:00 PM

Jdforrester-WMF removed a project: Patch-For-Review.Feb 25 2018, 9:06 PM

• Deskana closed this task as Resolved.Feb 26 2018, 4:09 PM

• Deskana triaged this task as Medium priority.

• Deskana set the point value for this task to 1.

• Elitre mentioned this in T188069: Text on category page is invisible when syntax highlighting is enabled.Feb 28 2018, 11:24 AM

Esanders mentioned this in T188473: [Regression pre-wmf.23] Weird wikitext formatting observed while editing with NWE when syntax highlighting is on.Feb 28 2018, 12:35 PM

Change 415273 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] VE: Use different approach for transparent text issue

https://gerrit.wikimedia.org/r/415273

gerritbot added a project: Patch-For-Review.Feb 28 2018, 12:37 PM

XanonymusX mentioned this in T171616: Font size changes, and then the editor crashes.Feb 28 2018, 11:50 PM

Ryasmeen edited projects, added Verified-in-Phase2; removed Patch-For-Review.Mar 1 2018, 11:45 PM

Change 415273 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] VE: Use different approach for transparent text issue

https://gerrit.wikimedia.org/r/415273

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Mar 6 2018, 5:00 PM