Ensure that all network handlers can gracefully handle HTTP Success codes other than 200.
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	Dbrant
	Feb 12 2018, 7:29 PM

Description

A recent task (T186933) has revealed a potential source of crashes, whereby a network response comes back as successful (i.e. HTTP 2xx status) but is not 200, meaning that the response body doesn't contain the structure that we expect. We need to ensure that the app handles these types of codes correctly and gracefully, and certainly doesn't crash.

Details

	Subject	Repo	Branch	Lines +/-
	Fix possible crash when fetching search results.	apps/android/wikipedia	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: T186933: 204 summary responses cause Android app to crash

Event Timeline

Dbrant created this task.Feb 12 2018, 7:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2018, 7:29 PM

Just to be explicit, the issue was probably not the non-200 error code but the empty payload.

Change 414719 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Fix possible crash when fetching search results.

https://gerrit.wikimedia.org/r/414719

gerritbot added a project: Patch-For-Review.Feb 26 2018, 5:35 PM

• Charlotte set the point value for this task to 3.Feb 26 2018, 5:41 PM

• Charlotte moved this task from Tech Debt Backlog to Android-app-release-v2.7.24x-H-Hot-pepper on the Wikipedia-Android-App-Backlog board.Feb 26 2018, 6:24 PM

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper); removed Wikipedia-Android-App-Backlog.

Change 414719 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix possible crash when fetching search results.

https://gerrit.wikimedia.org/r/414719

Dbrant moved this task from Android-app-release-v2.7.24x-H-Hot-pepper to Android-app-release-v2.7.24x-I-Ice-lolly on the Wikipedia-Android-App-Backlog board.Apr 3 2018, 6:32 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly); removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper).

• Charlotte edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly).May 7 2018, 4:53 PM

• Charlotte moved this task from Needs Triage to Tech Debt Backlog on the Wikipedia-Android-App-Backlog board.May 7 2018, 4:55 PM

• Charlotte closed this task as Resolved.Apr 9 2019, 5:18 PM