Page MenuHomePhabricator

Prompt me when entering a blank edit summary preference is causing warning prompt with HotCat filled in edit summary
Closed, InvalidPublic

Description

When using the HotCat gadget to add categories, saving the page causes the blank edit summary warning to be displayed even though HotCat has filled in the edit summary. Hitting the publish button a second time saves the page. This just started happening today. This is on enwiki.

Event Timeline

Aklapper changed the task status from Open to Stalled.Mar 3 2018, 4:08 PM
Aklapper added a subscriber: Perhelion.

Thanks for reporting this.

This just started happening today.

So https://en.wikipedia.org/wiki/MediaWiki:Gadget-HotCat.js loads from https://commons.wikimedia.org/wiki/MediaWiki:Gadget-HotCat.js .
https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-HotCat.js&action=history saw recent changes by @Perhelion. Has this been discussed already on https://commons.wikimedia.org/wiki/MediaWiki_talk:Gadget-HotCat.js to make sure this is a problem to fix in MediaWiki itself?
(In general, issues with on-wiki content like gadgets need to be discussed on-wiki, so it might turn out that Phab isn't the right place for this...just saying. :) )

matmarex subscribed.

The recent changes in HotCat to the handling of 'wpAutoSummary' are likely the problem. MediaWiki compares this value to the edit summary ('wpSummary') to decide whether to show that warning. HotCat now apparently reuses 'wpAutoSummary' to do something clever with edit tags that I don't really understand at a glance.

From my understanding, whatever the underlying problem is, it needs fixing in HotCat code which is on-wiki content.
On-wiki content is out of scope for Phabricator so I'm closing this task as invalid.