Query helper on embed.html always uses English language for labels of entities
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Lucas_Werkmeister_WMDE
	Mar 6 2018, 12:41 PM

Description

embed.html’s renderEdit initializes the QueryHelper without any arguments, which means that it uses its default English language instead of the selected one (from ULS, cookies, navigator, etc.). This is especially annoying in conjunction with T188110: Support multilingual query templates, because it means that you will see English labels inside a translated query template text.

Details

	Subject	Repo	Branch	Lines +/-
	Correctly initialize QueryHelper in embed.html	wikidata/query/gui	master	+4 -3

Customize query in gerrit

Related Objects

Mentioned In: rWDQG65bbc3ca7e02: Correctly initialize QueryHelper in embed.html
Mentioned Here: T188110: Support multilingual query templates

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 6 2018, 12:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2018, 12:41 PM

Lydia_Pintscher added a project: Wikidata.Mar 6 2018, 1:45 PM

Change 418956 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Correctly initialize QueryHelper in embed.html

https://gerrit.wikimedia.org/r/418956

gerritbot added a project: Patch-For-Review.Mar 12 2018, 5:22 PM

Lucas_Werkmeister_WMDE mentioned this in rWDQG65bbc3ca7e02: Correctly initialize QueryHelper in embed.html.Mar 12 2018, 5:25 PM

Change 418956 merged by jenkins-bot:
[wikidata/query/gui@master] Correctly initialize QueryHelper in embed.html

https://gerrit.wikimedia.org/r/418956

Lydia_Pintscher added a project: Wikidata-Ministry-Of-Magic.Mar 12 2018, 6:23 PM

• Jonas moved this task from Tasks to Done on the Wikidata-Ministry-Of-Magic board.Mar 13 2018, 10:53 AM

• Jonas moved this task from Backlog to Done on the Wikidata Query UI board.

• Jonas closed this task as Resolved.Mar 21 2018, 12:53 PM