Page MenuHomePhabricator

label not shown for grammatical feature in diff of a Form
Closed, ResolvedPublic3 Estimated Story Points

Description

When viewing a diff of a change of the grammatical feature of a Form the label for the item is not shown and instead only the Q-ID.

The label should be shown in the user's ULS language (or a fallback when not available - same fallback chain as everywhere else for item labels).

example diff:

gramfeat-diff.png (213×1 px, 15 KB)

Example diff with item labels shown:

lexcat-diff2.png (234×1 px, 23 KB)

The same diff in qqx language with fallback:
lexcat-diff3.png (95×1 px, 9 KB)

To be done after T189187.
The solution seem to be to use the correct item ID formatter in the code visualizing the grammatical feature differences in the lexeme diff. The formatter will be recognized on the course of T189187.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher renamed this task from label not shown for grammatical feature in diff to label not shown for grammatical feature in diff of a Form.Mar 8 2018, 9:34 AM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher raised the priority of this task from Low to Medium.

Similar to T189187 (just a note so that notes about the technical points can be compared)

WMDE-leszek set the point value for this task to 3.Mar 13 2018, 10:47 AM

Change 420684 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Format grammatical feature items in the lexeme diff

https://gerrit.wikimedia.org/r/420684

Change 420684 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Format grammatical feature items in the lexeme diff

https://gerrit.wikimedia.org/r/420684