Page MenuHomePhabricator
Create Task
Maniphest T189320

Wikidata external changes have usernames with "wikidata>" prefixes
Closed, ResolvedPublic
Actions

Description

Screenshot of enwiki Wikidata recent changes:

obrazek.png (391×1 px, 60 KB)

Details

SubjectRepoBranchLines +/-
Use only local part of username when building the RC linemediawiki/extensions/Wikibasewmf/1.31.0-wmf.24+2 -1
Add ExternalUserNames::getLocal() to get local part of usernamemediawiki/corewmf/1.31.0-wmf.24+34 -0
Use only local part of username when building the RC linemediawiki/extensions/Wikibasemaster+2 -1
Add ExternalUserNames::getLocal() to get local part of usernamemediawiki/coremaster+34 -0
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Mar 9 2018, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2018, 6:53 PM
Lydia_Pintscher triaged this task as Unbreak Now! priority.Mar 9 2018, 6:59 PM
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.
Lydia_Pintscher added subscribers: Ladsgroup, Lydia_Pintscher.

@Ladsgroup Can you have a look?

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 9 2018, 6:59 PM
Ladsgroup added a comment.Mar 9 2018, 7:00 PM

That's completely intentional. The frontend is broken though. Let me take a look

gerritbot subscribed.Mar 9 2018, 7:33 PM

Change 418028 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@master] Add ExternalUserNames::getLocal() to get local part of username

https://gerrit.wikimedia.org/r/418028

gerritbot added a project: Patch-For-Review.Mar 9 2018, 7:33 PM
gerritbot added a comment.Mar 9 2018, 7:45 PM

Change 418030 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Use only local part of username when building the RC line

https://gerrit.wikimedia.org/r/418030

Ladsgroup claimed this task.Mar 9 2018, 7:47 PM
Ladsgroup added a project: Wikidata-Ministry-Of-Magic.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 9 2018, 7:47 PM
Ladsgroup moved this task from Tasks to Needs Review on the Wikidata-Ministry-Of-Magic board.Mar 9 2018, 7:47 PM

When this gets merged, we can deploy the backport if you think it's needed. Also I can deploy the backport now or in Monday.

gerritbot added a comment.Mar 9 2018, 8:53 PM

Change 418028 merged by jenkins-bot:
[mediawiki/core@master] Add ExternalUserNames::getLocal() to get local part of username

https://gerrit.wikimedia.org/r/418028

Lydia_Pintscher added a comment.Mar 9 2018, 8:59 PM

Thanks for fixing it so quickly! I think Monday is fine.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 9 2018, 9:01 PM
matej_suchanek lowered the priority of this task from Unbreak Now! to High.Mar 10 2018, 9:26 AM
• Jonas moved this task from Needs Review to Blocked on the Wikidata-Ministry-Of-Magic board.Mar 12 2018, 8:10 AM
• Jonas moved this task from Blocked to Done on the Wikidata-Ministry-Of-Magic board.
gerritbot added a comment.Mar 12 2018, 11:45 AM

Change 418030 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use only local part of username when building the RC line

https://gerrit.wikimedia.org/r/418030

Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Mar 13 2018, 11:26 AM
Mbch331 merged a task: T189720: Some Wikidata edits inject wikidata> in usernames from the project.Mar 14 2018, 6:24 PM
Mbch331 added a subscriber: stjn.
Ladsgroup added a comment.Mar 14 2018, 6:32 PM

I wanted to backport this but I keep forgetting. Will it in the midnight SWAT (UTC)

gerritbot added a comment.Mar 14 2018, 11:05 PM

Change 419618 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/core@wmf/1.31.0-wmf.24] Add ExternalUserNames::getLocal() to get local part of username

https://gerrit.wikimedia.org/r/419618

gerritbot added a comment.Mar 14 2018, 11:09 PM

Change 419619 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.24] Use only local part of username when building the RC line

https://gerrit.wikimedia.org/r/419619

gerritbot added a comment.Mar 14 2018, 11:59 PM

Change 419618 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.24] Add ExternalUserNames::getLocal() to get local part of username

https://gerrit.wikimedia.org/r/419618

gerritbot added a comment.Mar 15 2018, 12:16 AM

Change 419619 merged by Gergő Tisza:
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.24] Use only local part of username when building the RC line

https://gerrit.wikimedia.org/r/419619

Stashbot subscribed.Mar 15 2018, 12:22 AM

Mentioned in SAL (#wikimedia-operations) [2018-03-15T00:22:56Z] <tgr@tin> Synchronized php-1.31.0-wmf.24/includes/user/ExternalUserNames.php: T189320 Add ExternalUserNames::getLocal() to get local part of username (duration: 01m 15s)

Stashbot added a comment.Mar 15 2018, 12:25 AM

Mentioned in SAL (#wikimedia-operations) [2018-03-15T00:25:17Z] <tgr@tin> Synchronized php-1.31.0-wmf.24/extensions/Wikibase/client/includes/RecentChanges/ExternalChangeFactory.php: T189320 Use only local part of username when building the RC line (duration: 01m 18s)

Ladsgroup closed this task as Resolved.Mar 15 2018, 12:31 AM
Ladsgroup moved this task from Incoming to Done on the User-Ladsgroup board.

Okay, This is backported :)

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 15 2018, 5:00 AM
Liuxinyu970226 unsubscribed.Mar 20 2018, 3:32 AM
matej_suchanek mentioned this in T190530: Enhanced recent changes don't format external usernames well in contributors summary.Mar 23 2018, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL