Maniphest T192512

Sanitizer::validateAttributes() strips relative URLs from anchor tags
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	dbarratt
	Apr 18 2018, 11:53 PM

Description

In T165535 I was attempting to use Sanitizer::removeHTMLtags() to remove all of the HTML tags from the parsed wikitext except for anchor tags. However, I noticed that the href attribute was always stripped from the anchor. Upon further investigation, I found this note:

this also drops all relative URLs

We should, at a minimum, support root-relative links.

Related Objects

Mentioned In: T165535: Block notices on mobile web for logged-in users provide insufficient information about the block
Mentioned Here: T165535: Block notices on mobile web for logged-in users provide insufficient information about the block

Event Timeline

dbarratt created this task.Apr 18 2018, 11:53 PM

Restricted Application added a project: Product-Analytics. · View Herald TranscriptApr 18 2018, 11:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

dbarratt renamed this task from Sanitizer::validateAttributes() strips root-relative URLs from anchor tags to Sanitizer::validateAttributes() strips relative URLs from anchor tags.Apr 18 2018, 11:54 PM

Krinkle mentioned this in T165535: Block notices on mobile web for logged-in users provide insufficient information about the block.Apr 19 2018, 12:01 AM

• Phabricator_maintenance removed a project: Product-Analytics.Apr 19 2018, 12:19 AM

dbarratt added a project: Technical-Debt.Apr 30 2018, 2:05 PM

Sanitizer::validateAttributes() strips relative URLs from anchor tagsOpen, Needs TriagePublicActions

Description

Related Objects

Event Timeline

Sanitizer::validateAttributes() strips relative URLs from anchor tags
Open, Needs TriagePublic
Actions