Page MenuHomePhabricator
Create Task
Maniphest T195375

Show changes in moved paragraphs on most wikis
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Motivation
Currently, the new wikidiff2 feature of showing moved paragraphs and its changes within is only visible on de-wiki. Now it should come to all other wikis whose languages are diffed on a word basis. Thai, unified han and japanese are diffed on character basis and will thus be treated in the next step.

Targeted SWAT slot
May 30th 2018, 3 pm UTC+2

Task

  • Change the config file to set the moved paragraph threshold up for all wikis but thai, unified han and japanese
  • Claim SWAT deploy window
  • SWAT deploy the change

Details

SubjectRepoBranchLines +/-
Enable detection of changes in moved paragraphs on most wikisoperations/mediawiki-configmaster+26 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lea_WMDE triaged this task as Medium priority.May 23 2018, 1:27 PM
Lea_WMDE created this task.
Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-05-23.
Lea_WMDE renamed this task from PLACEHOLDER TICKET config change to Show changes in moved paragraphs on all wikis.May 23 2018, 2:13 PM
Lea_WMDE updated the task description. (Show Details)
Lea_WMDE edited parent tasks, added: T190717: Update wikidiff2 library on the WMF production cluster; removed: T146781: Show changes in moved text chunks (C++).
Lea_WMDE renamed this task from Show changes in moved paragraphs on all wikis to Show changes in moved paragraphs on most wikis.May 24 2018, 11:50 AM
Lea_WMDE updated the task description. (Show Details)
IKhitron subscribed.May 24 2018, 3:30 PM
WMDE-Fisch claimed this task.May 29 2018, 9:40 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-05-23 board.
gerritbot subscribed.May 29 2018, 2:23 PM

Change 436017 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[operations/mediawiki-config@master] Enable detection of changes in moved paragraphs on most wikis

https://gerrit.wikimedia.org/r/436017

gerritbot added a project: Patch-For-Review.May 29 2018, 2:23 PM
WMDE-Fisch added a comment.May 29 2018, 2:31 PM

I will be in the IRC during SWAT:

https://wikitech.wikimedia.org/wiki/Deployments#Wednesday,_May_30
https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1792983&oldid=1792964

WMDE-Fisch updated the task description. (Show Details)May 29 2018, 2:31 PM
WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-05-23 board.
He7d3r subscribed.May 29 2018, 6:32 PM
gerritbot added a comment.May 30 2018, 1:06 PM

Change 436017 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable detection of changes in moved paragraphs on most wikis

https://gerrit.wikimedia.org/r/436017

Stashbot subscribed.May 30 2018, 1:12 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-30T13:12:31Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:436017|Enable detection of changes in moved paragraphs on most wikis (T195375)]] (duration: 01m 02s)

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-05-23 board.May 30 2018, 2:01 PM

Live now, can be seen for example in

https://en.wikipedia.org/w/index.php?diff=779422017&oldid=772944792&title=Honeyguide&type=revision

WMDE-Fisch updated the task description. (Show Details)May 30 2018, 2:01 PM
Lea_WMDE awarded a token.May 30 2018, 2:06 PM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-05-23 board.May 30 2018, 2:52 PM
RandomDSdevel awarded a token.May 31 2018, 10:22 PM
Lea_WMDE closed this task as Resolved.Jun 12 2018, 8:15 AM
Aklapper mentioned this in T197157: New diffs show lines in the wrong order.Jun 14 2018, 7:25 AM
Yair_rand mentioned this in T15462: Enhance line matching in diffs.Jun 21 2018, 7:20 AM
• Vvjjkkii renamed this task from Show changes in moved paragraphs on most wikis to 8fcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed WMDE-Fisch as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 8fcaaaaaaa to Show changes in moved paragraphs on most wikis.Jul 2 2018, 4:40 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to WMDE-Fisch.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot set the point value for this task to 3.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
IKhitron added a comment.EditedJan 20 2019, 12:53 PM

Hi there. Is this a bug, so I should open a new phab ticket? Thank you.
https://ru.wikipedia.org/w/index.php?title=MediaWiki:Gadget-markadmins.json&diff=0&oldid=97533626
As you can see, DrBug is shown as moved, instead of Michgrig, two lines below.

image.png (585×1 px, 12 KB)

IKhitron added a subscriber: Jack_who_built_the_house.Jan 20 2019, 12:55 PM
Lea_WMDE added a comment.Feb 5 2019, 4:48 PM

@IKhitron thanks for reporting (and fixing the ticket). I created a new subticket for it and we will look into it.

IKhitron added a comment.Feb 5 2019, 4:49 PM

Thanks a lot.

Lea_WMDE closed subtask T215293: Moved 100% match was not found (Michgrig bug) as Resolved.Mar 4 2019, 10:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL