Page MenuHomePhabricator
Create Task
Maniphest T209012

Preview on a new site breaks and leads to loose of the site content
Closed, ResolvedPublic
Actions

Description

Bildschirmfoto zu 2018-11-08 01-04-52.png (504×1 px, 160 KB)

Details

SubjectRepoBranchLines +/-
Revert "Disable wmgUseTwoColConflict everywhere"operations/mediawiki-configmaster+1 -3
Re-enable wmgUseTwoColConflict on dewikioperations/mediawiki-configmaster+1 -0
Re-enable wmgUseTwoColConflict on group0 onlyoperations/mediawiki-configmaster+1 -0
Fix harmless edits turning into conflictsmediawiki/extensions/TwoColConflictwmf/1.33.0-wmf.3+1 -0
Disable wmgUseTwoColConflict everywhereoperations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

MichaelSchoenitzer created this task.Nov 8 2018, 12:11 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptNov 8 2018, 12:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MichaelSchoenitzer triaged this task as High priority.Nov 8 2018, 12:11 AM
revi subscribed.Nov 8 2018, 6:24 AM

069A36BF-76A9-4192-8B9A-D72FCECC389A.png (2×1 px, 392 KB)

Preview showed me this. (Sorry, mobile) some sort of Regression , I guess? I never saw this kind of stuff.

Lea_WMDE added a comment.Nov 8 2018, 10:44 AM

Thanks for reporting the issue! We are disabling the feature until we found the bug, this really does not sound good. If you are NOT a beta feature user of TwoColConflict, and still had these issues, please let us know!

gerritbot subscribed.Nov 8 2018, 10:47 AM

Change 472409 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Disable wmgUseTwoColConflict everywhere

https://gerrit.wikimedia.org/r/472409

gerritbot added a project: Patch-For-Review.Nov 8 2018, 10:47 AM

Change 472409 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable wmgUseTwoColConflict everywhere

https://gerrit.wikimedia.org/r/472409

thiemowmde mentioned this in rESCC1057c93ba400: Fix harmless edits turning into conflicts.Nov 8 2018, 10:49 AM
gerritbot added a comment.Nov 8 2018, 10:50 AM

Change 472175 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

Stashbot subscribed.Nov 8 2018, 10:52 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T10:52:29Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Disable wmgUseTwoColConflict everywhere T209012 T208840 T195724 (duration: 00m 58s)

Stashbot mentioned this in T208840: Monitor user reports about imaginary conflicts.Nov 8 2018, 10:52 AM
Stashbot mentioned this in T195724: Adapt Save-, Preview- and Cancel buttons to new version (No. 8).
thiemowmde mentioned this in rESCC5dddd52fcf45: Fix harmless edits turning into conflicts.Nov 8 2018, 10:54 AM
gerritbot added a comment.Nov 8 2018, 10:54 AM

Change 472411 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

• MichaelSchoenitzer_WMDE subscribed.Nov 8 2018, 11:00 AM
MichaelSchoenitzer unsubscribed.Nov 8 2018, 11:00 AM
gerritbot added a comment.Nov 8 2018, 12:23 PM

Change 472175 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@wmf/1.33.0-wmf.3] Fix harmless edits turning into conflicts

https://gerrit.wikimedia.org/r/472175

Stashbot mentioned this in T205942: Some edit submits get fatal InvalidArgumentException "The title does not refer to an existing page" from TwoColConflict extension.Nov 8 2018, 12:29 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:29:33Z] <zfilipin@deploy1001> Synchronized php-1.33.0-wmf.3/extensions/TwoColConflict: SWAT: [[gerrit:472175|Fix harmless edits turning into conflicts (T205942 T208840 T209012 T209036)]] (duration: 00m 55s)

Stashbot mentioned this in T209036: The title "Foo" does not refer to an existing page.Nov 8 2018, 12:29 PM
gerritbot added a comment.Nov 8 2018, 12:48 PM

Change 472431 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

gerritbot added a comment.Nov 8 2018, 12:51 PM

Change 472431 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on group0 only

https://gerrit.wikimedia.org/r/472431

Stashbot added a comment.Nov 8 2018, 12:53 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T12:53:22Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on group0 only T205942 T208840 T209012 T209036 (duration: 00m 54s)

gerritbot added a comment.Nov 8 2018, 1:02 PM

Change 472434 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

gerritbot added a comment.Nov 8 2018, 1:04 PM

Change 472434 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-enable wmgUseTwoColConflict on dewiki

https://gerrit.wikimedia.org/r/472434

Stashbot added a comment.Nov 8 2018, 1:07 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T13:07:46Z] <addshore@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Re-enable wmgUseTwoColConflict on dewiki - T205942 T208840 T209012 T209036 (duration: 00m 53s)

Wargo subscribed.Nov 8 2018, 5:03 PM
gerritbot added a comment.Nov 8 2018, 7:26 PM

Change 472411 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Disable wmgUseTwoColConflict everywhere"

https://gerrit.wikimedia.org/r/472411

Stashbot added a comment.Nov 8 2018, 7:35 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-08T19:35:40Z] <thcipriani@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:472411|Revert "Disable wmgUseTwoColConflict everywhere"]] T205942 T208840 T209012 T209036 (duration: 00m 54s)

thiemowmde closed this task as Resolved.Nov 8 2018, 7:36 PM
thiemowmde claimed this task.
thiemowmde removed a project: Patch-For-Review.
RandomDSdevel awarded a token.Nov 13 2018, 2:35 AM
Tobi_WMDE_SW mentioned this in T210591: Create incident report for the get-editconflict-everywhere issue.Nov 28 2018, 9:55 AM
thiemowmde mentioned this in T210758: Add browser test for preview functionality to MediaWiki core.Nov 29 2018, 6:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL