Maniphest T209991

Raise maximum zoom level for auto-positioning in Kartographer
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pikne
	Nov 20 2018, 5:57 PM

Description

Auto-positioning is now enabled for Kartographer (T158919), but for some reason it has maximum zoom level set to 13. Is the latter necessary? Higher zoom level would be useful when displaying e.g. building outlines or shorter streets (like Q31280181). If suitable then I'd suggest dropping this restriction or changing it to level 19 that matches max zoom in Kartographer.

If I'm not mistaken it's set here.

Details

	Subject	Repo	Branch	Lines +/-
	Removing fallbackzoom default	mediawiki/extensions/Kartographer	master	+1 -4

Customize query in gerrit

Related Objects

Mentioned Here: T158919: Enable auto-positioned snapshot on Kartographer side

Event Timeline

Pikne created this task.Nov 20 2018, 5:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2018, 5:57 PM

MSantos triaged this task as Low priority.Nov 27 2018, 4:01 PM

MSantos added a project: Product-Infrastructure-Team-Backlog-Deprecated.

MSantos claimed this task.Nov 27 2018, 9:51 PM

MSantos edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

MSantos moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

MSantos merged a task: T138793: How should we handle missing zoom when lat/long are given?.Dec 13 2018, 12:43 PM

MSantos added subscribers: Yurik, • JGirault, Zppix.

MSantos moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Dec 13 2018, 4:57 PM

This seems to be implemented for snapshots now, e.g. zoom level 17 is used here. Thank you!
I now note that zoom level 13 is also set here in Kartographer as "fallbackZoom". I think it would be better to remove this restriction too.

MSantos closed this task as Resolved.Apr 12 2019, 4:33 PM

Change 503406 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/Kartographer@master] Removing fallbackzoom default

https://gerrit.wikimedia.org/r/503406

gerritbot added a project: Patch-For-Review.Apr 12 2019, 5:15 PM

Change 503406 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Removing fallbackzoom default