Page MenuHomePhabricator
Create Task
Maniphest T211136

Wikipedia Library Server Error
Closed, ResolvedPublic
Actions

Description

When I try to log in to the site using the blue "Log in" button in home page I get error:

"Internal server error
Something went wrong.
Please email us about this error at wikipedialibrary@wikimedia.org or report it to us on Phabricator (?). "

The link there is https://wikipedialibrary.wmflabs.org/oauth/login/

If I use the "Log in" link in top-right corner, it succesfully logs me in. There the link is https://wikipedialibrary.wmflabs.org/oauth/login/?next=/

Event Timeline

Stryn created this task.Dec 4 2018, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2018, 6:30 PM
Samwalton9-WMF subscribed.Dec 4 2018, 7:01 PM

Looks like the issue is from these commits:

authorization.py: https://github.com/WikipediaLibrary/TWLight/commit/d099990bc4cd9c9575ff4d0854764086636a9a42
base.html: https://github.com/WikipediaLibrary/TWLight/commit/1ee8e60cb50ed1f772a31bce849468f060f9e7d2#diff-6fca8688c8ab8b0f2ff9dfce2ec1c083

Seems like home.html needs the same logic as was added to base.html

jsn.sherman claimed this task.Dec 4 2018, 7:34 PM
jsn.sherman subscribed.

pushed hotfix in git. Will get it to live site asap

jsn.sherman closed this task as Resolved.Dec 4 2018, 7:44 PM

hotfix in place. verified that things are happy.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL