Pressing 'Enter' not submitting form after OOUI v0.30.0 releases in some cases
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xaosflux
	Jan 11 2019, 2:47 PM

Description

On certain forms, possibly only in combination with certain other elements, pressing enter in expected locations is no longer submitting the form, but instead changing focus to another field.

Reports from enwiki : https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=877878700#Hitting_%22enter%22_in_the_edit_summary_box_no_longer_saves_the_page

Able to reproduce on testwiki with the MOVE dialog:

Go to a page
Attempt to move it
Enter new title and reason, press ENTER in the REASON field
FAIL: Instead of submitting, the input focus is changing to the namespace selector

Possibly related to T213240 ?

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.30.2	mediawiki/core	master	+677 -544
OOUI: Backport Ie43a0a346fea2dd2fda540d62f24410de1bc0d76	mediawiki/core	wmf/1.33.0-wmf.12	+1 -0
OOUI: Backport Ie43a0a346fea2dd2fda540d62f24410de1bc0d76	mediawiki/core	master	+1 -0
DropdownWidget: `$handle` needs to carry `type="button"`	oojs/ui	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T213548: When focus in is "Other/additional reasons" text field on "Delete" page, pressing Enter instead activates "Reason" dropdown field above
Mentioned Here: rGOJU43e5d6277fc4: DropDownWidget: Turn handle into `button` and add ARIA attribute
T213240: When pressing enter/return, file caption input text boxes should not add a newline

Event Timeline

Xaosflux created this task.Jan 11 2019, 2:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2019, 2:47 PM

Xaosflux updated the task description. (Show Details)Jan 11 2019, 2:51 PM

Xaosflux edited projects, added OOUI; removed OOUI (OOUI-0.30.0).Jan 11 2019, 2:53 PM

Xaosflux edited projects, added OOUI (OOUI-0.30.0); removed OOUI.

Xaosflux edited projects, added OOUI; removed OOUI (OOUI-0.30.0).

Galobtter subscribed.Jan 11 2019, 2:54 PM

Amorymeltzer subscribed.Jan 11 2019, 3:51 PM

Amorymeltzer mentioned this in T213548: When focus in is "Other/additional reasons" text field on "Delete" page, pressing Enter instead activates "Reason" dropdown field above.Jan 11 2019, 3:58 PM

Aklapper merged a task: T213548: When focus in is "Other/additional reasons" text field on "Delete" page, pressing Enter instead activates "Reason" dropdown field above.Jan 11 2019, 3:59 PM

Aklapper added a subscriber: Equinox.

Volker_E added subscribers: Esanders, matmarex.Jan 11 2019, 5:22 PM

@matmarex First guess, some forms are searching for the nearest button instead of the submit button when 'enter' is pressed. Now that Dropdown features a 'button' internally, 'enter' is activated on that.

Volker_E triaged this task as High priority.Jan 11 2019, 5:40 PM

Volker_E renamed this task from enter not submitting form after ooui v0.30.0 in some cases to Pressing 'Enter' not submitting form after OOUI v0.30.0 releases in some cases.Jan 11 2019, 5:46 PM

Result assumedly from 43e5d6277fc4bab5a4b431121a8ad09d8cbe151d

Button misses type=button. After all it's the HTML, stupid.

Change 483833 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] DropdownWidget: $handle needs to carry type="button"

https://gerrit.wikimedia.org/r/483833

gerritbot added a project: Patch-For-Review.Jan 11 2019, 7:35 PM

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Jan 11 2019, 7:53 PM

Change 483833 merged by jenkins-bot:
[oojs/ui@master] DropdownWidget: $handle needs to carry type="button"

https://gerrit.wikimedia.org/r/483833

AntiCompositeNumber subscribed.Jan 13 2019, 12:18 AM

Volker_E moved this task from Reviewing to OOUI-0.30.2 on the OOUI board.Jan 13 2019, 3:09 AM

Volker_E edited projects, added OOUI (OOUI-0.30.2); removed OOUI.

Change 484281 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] OOUI: Backport Ie43a0a346fea2dd2fda540d62f24410de1bc0d76

https://gerrit.wikimedia.org/r/484281

This seems like a very annoying problem, so I'm going to backport the fix. It will be deployed to Wikimedia wikis later today.

Change 484281 merged by jenkins-bot:
[mediawiki/core@master] OOUI: Backport Ie43a0a346fea2dd2fda540d62f24410de1bc0d76

https://gerrit.wikimedia.org/r/484281

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 14 2019, 9:00 PM

Change 484291 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.33.0-wmf.12] OOUI: Backport Ie43a0a346fea2dd2fda540d62f24410de1bc0d76

https://gerrit.wikimedia.org/r/484291

https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190115T0000

Change 484291 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.12] OOUI: Backport Ie43a0a346fea2dd2fda540d62f24410de1bc0d76

https://gerrit.wikimedia.org/r/484291

Mentioned in SAL (#wikimedia-operations) [2019-01-15T00:34:35Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.12/resources/lib/ooui/oojs-ui-core.js: OOUI backport (T213544) (duration: 00m 46s)

This issue is resolved now. Thanks for reporting it!

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 15 2019, 1:01 AM

Change 486131 had a related patch set uploaded (by Jforrester; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.30.2

https://gerrit.wikimedia.org/r/486131

Change 486131 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.2