Page MenuHomePhabricator
Create Task
Maniphest T214179

mw.ext.data.get Lua call returns false
Closed, ResolvedPublic
Actions

Description

About 2 hours ago, problem start appearing in some articles at ruwiki.
It was reported at forum here. Example of affected article: Новограц, Жаклин.
At infobox Ошибка Lua в Модуль:Wikidata/Medals на строке 66: attempt to index upvalue 'awardsOrder' (a boolean value) error can be read.
Line # 66 of module accesses variable awardsOrder, which is initialized at line # 3:
local awardsOrder = mw.ext.data.get( "Wikidata/awards order.tab" )
When I try to check what value this variable have, I see result false.
It looks like mw.ext.data.get call should return something else.
To reproduce problem: open this link, paste mw.logObject(mw.ext.data.get("Wikidata/awards order.tab")) at debug console and press Enter.

I'm not sure if my report is correct, so close it if my description is wrong and problem is somewhere else.

Details

SubjectRepoBranchLines +/-
Follow-up 7695dd8be7, fix API response handlingmediawiki/extensions/JsonConfigmaster+3 -3
Revert "JCCache: Explicit load the main slot to avoid API warnings"mediawiki/extensions/JsonConfigmaster+0 -2
Revert "JCCache: Explicit load the main slot to avoid API warnings"mediawiki/extensions/JsonConfigwmf/1.33.0-wmf.13+0 -2
Customize query in gerrit

Related Objects

Event Timeline

Vort created this task.Jan 18 2019, 5:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2019, 5:02 PM
Vort added a project: Scribunto.Jan 18 2019, 5:10 PM
Vort added a project: Commons-Datasets.Jan 18 2019, 6:50 PM
Yurik subscribed.Jan 18 2019, 7:10 PM

The actual data table is present. Was there any related code changes in MW?

Yurik added a subscriber: Anomie.Jan 18 2019, 7:27 PM
Anomie moved this task from Backlog to External on the Scribunto board.Jan 18 2019, 7:28 PM
JJMC89 added subscribers: Legoktm, JJMC89.Jan 19 2019, 3:09 AM

This issue was also reported on the English Wikipedia.

JJMC89 added a subscriber: Johnuniq.Jan 19 2019, 3:09 AM
Legoktm triaged this task as Unbreak Now! priority.Jan 19 2019, 4:38 AM
Legoktm added a project: JsonConfig.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptJan 19 2019, 4:38 AM
Legoktm added a comment.Jan 19 2019, 4:43 AM
legoktm@mwmaint1002:~$ mwscript eval.php --wiki=testwiki
> $titleStr='Wikidata/awards order.tab';

> $t=JsonConfig\JCSingleton::parseTitle( $titleStr, NS_DATA );

> var_dump($t);
object(JsonConfig\JCTitle)#459 (6) {
  ["config":"JsonConfig\JCTitle":private]=>
  object(stdClass)#450 (11) {
    ["namespace"]=>
    int(486)
    ["nsName"]=>
    string(4) "Data"
    ["pattern"]=>
    string(9) "/.\.tab$/"
    ["license"]=>
    string(7) "CC0-1.0"
    ["isLocal"]=>
    bool(false)
    ["remote"]=>
    object(stdClass)#451 (3) {
      ["url"]=>
      string(39) "https://commons.wikimedia.org/w/api.php"
      ["username"]=>
      string(0) ""
      ["password"]=>
      string(0) ""
    }
    ["model"]=>
    string(18) "Tabular.JsonConfig"
    ["cacheExp"]=>
    int(86400)
    ["cacheKey"]=>
    string(0) ""
    ["flaggedRevs"]=>
    bool(false)
    ["store"]=>
    bool(false)
  }
  ["namespace":protected]=>
  int(486)
  ["dbkey":protected]=>
  string(25) "Wikidata/awards_order.tab"
  ["fragment":protected]=>
  string(0) ""
  ["interwiki":protected]=>
  string(0) ""
  ["prefixedText"]=>
  NULL
}

> $c=JsonConfig\JCSingleton::getContentFromLocalCache($t);

> var_dump($c);
NULL

> $realC=JsonConfig\JCSingleton::getContent($t);

> var_dump($realC);
bool(false)

Next: why isn't JCSingleton::getContent() working?

Legoktm claimed this task.Jan 19 2019, 4:48 AM
Legoktm added a project: Regression.
Legoktm added a subscriber: Jdforrester-WMF.

7695dd8be7ecba2ef6c50adc6353d89f20e87c94 changed the API parameters but did not update the code handling the API response to update. I'll do a straight revert for now, and submit another patch to actually fix the issue.

gerritbot subscribed.Jan 19 2019, 4:49 AM

Change 485360 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/JsonConfig@master] Revert "JCCache: Explicit load the main slot to avoid API warnings"

https://gerrit.wikimedia.org/r/485360

gerritbot added a project: Patch-For-Review.Jan 19 2019, 4:49 AM

Change 485361 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/JsonConfig@wmf/1.33.0-wmf.13] Revert "JCCache: Explicit load the main slot to avoid API warnings"

https://gerrit.wikimedia.org/r/485361

gerritbot added a comment.Jan 19 2019, 4:54 AM

Change 485362 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/JsonConfig@master] Follow-up 7695dd8be7, fix API response handling

https://gerrit.wikimedia.org/r/485362

gerritbot added a comment.Jan 19 2019, 5:03 AM

Change 485361 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@wmf/1.33.0-wmf.13] Revert "JCCache: Explicit load the main slot to avoid API warnings"

https://gerrit.wikimedia.org/r/485361

Stashbot subscribed.Jan 19 2019, 5:18 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-19T05:18:11Z] <legoktm@deploy1001> Synchronized php-1.33.0-wmf.13/extensions/JsonConfig/includes/JCCache.php: Revert "JCCache: Explicit load the main slot to avoid API warnings" - T214179 (duration: 00m 58s)

Legoktm added a comment.Jan 19 2019, 5:20 AM

OK, should be fixed now. I tried out the reproduction in the description and it worked:

To reproduce problem: open this link, paste mw.logObject(mw.ext.data.get("Wikidata/awards order.tab")) at debug console and press Enter.

Can someone else confirm before I mark this as resolved?

JJMC89 closed this task as Resolved.Jan 19 2019, 5:32 AM

This one is working again.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 19 2019, 6:00 AM
Liuxinyu970226 unsubscribed.Jan 20 2019, 3:30 PM
gerritbot added a comment.Jan 22 2019, 7:56 AM

Change 485360 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Revert "JCCache: Explicit load the main slot to avoid API warnings"

https://gerrit.wikimedia.org/r/485360

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.14; 2019-01-22); removed MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 22 2019, 8:00 AM
Voyagerim subscribed.Jan 25 2019, 8:10 AM
In T214179#4894116, @JJMC89 wrote:

This one is working again.

But does't work on ruwiki..

Voyagerim reopened this task as Open.Jan 25 2019, 8:11 AM
Voyagerim added a comment.Jan 25 2019, 9:21 AM

https://ru.wikipedia.org/w/api.php?action=scribunto-console&format=xml&title=%D0%9C%D0%BE%D0%B4%D1%83%D0%BB%D1%8C%3A123&question=mw.logObject(mw.ext.data.get(%27USGS_Earthquakes.tab%27))&clear=1 returns:
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<api type="normal" print="nil " return="" session="753554712" sessionSize="53" sessionMaxSize="500000" sessionIsNew=""/>
proof: https://imgur.com/a/W9krdrd

But for some users it works fine:
proof: https://imgur.com/a/1agNwpS

seems something went wrong..
UPD: Server Cache and browser cache were purged also, no effect

Voyagerim added a comment.Jan 25 2019, 5:20 PM

I've deleted cookies and browser history (Chrome), it helps

Voyagerim closed this task as Resolved.Jan 25 2019, 5:21 PM
Voyagerim reopened this task as Open.Jan 25 2019, 6:12 PM

After some minuts, it went wrong again

Ghuron subscribed.Feb 6 2019, 5:17 PM

It looks like it depends whenever PHP7 setting is tuned on or off. When its off, problem disaperars, when its on, action=purge any article that uses it and you will get "false" when calling mw.ext.data.get()

SerDIDG awarded a token.Feb 6 2019, 5:20 PM
SerDIDG subscribed.
Voyagerim added a comment.Feb 6 2019, 5:35 PM

@Ghuron, confirmed. When I've turned PHP7 off, the problem dissapeared

Legoktm closed this task as Resolved.Feb 6 2019, 5:48 PM
Legoktm mentioned this in T215444: mw.ext.data.get from JsonConfig doesn't work with PHP 7.

That's a separate issue then, so I've filed it as a separate task. Let's discuss it there: T215444: mw.ext.data.get from JsonConfig doesn't work with PHP 7.

gerritbot added a comment.Feb 7 2019, 3:15 AM

Change 485362 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Follow-up 7695dd8be7, fix API response handling

https://gerrit.wikimedia.org/r/485362

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.17; 2019-02-12); removed MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Feb 7 2019, 4:01 AM
Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:27 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL