CookieWarning does not interact correctly with MobileFrontend
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dikay01
	Jan 28 2019, 9:41 AM

Description

Mediawiki 1.31: The message that CookieWarning produces does not seem to go through the MobileFrontend extension. Rather, the cookie message that appears on the mobile phone seems to be "below" (and partly overlapped by) the MobileFrontend-formatted text. It also does not appear to have the same width as the screen.

To see this bug in action, go to http://strucbio.biologie.uni-konstanz.de/ccp4wiki/index.php/Special:Version?useformat=mobile and inspect the top of the page - it's corrupted. It should look similar to the desktop version, http://strucbio.biologie.uni-konstanz.de/ccp4wiki/index.php/Special:Version (you need a desktop browser).

I have no idea if this is CookieWarning's fault, or MobileFrontend's.

Related Objects

Mentioned Here: T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook

Event Timeline

Dikay01 created this task.Jan 28 2019, 9:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2019, 9:41 AM

Dikay01 updated the task description. (Show Details)Jan 28 2019, 9:42 AM

Dikay01 updated the task description. (Show Details)Jan 28 2019, 9:48 AM

Dikay01 added projects: MobileFrontend, MediaWiki-extensions-CookieWarning.Jan 28 2019, 10:27 AM

Looks specific to CookieWarning compatibility with Vector on mobile.
I think resources/ext.CookieWarning/ext.CookieWarning.mobile.less is actually a skinStyle for Minerva but it's being loaded on non-Minerva skins

"ext.CookieWarning.styles": {
			"styles": "resources/ext.CookieWarning/ext.CookieWarning.less"
		},
		"ext.CookieWarning.mobile.styles": {
			"styles": "resources/ext.CookieWarning/ext.CookieWarning.mobile.less",
			"targets": [
				"mobile"
			]
		},

should probably become:

"ext.CookieWarning.styles": {
			"targets": [
				"desktop", "mobile"
			]
   "skinStyles": [
			"vector": "resources/ext.CookieWarning/ext.CookieWarning.less"
			"minerva": "resources/ext.CookieWarning/ext.CookieWarning.mobile.less",

		],
]

Thanks! As a workaround, we installed the Minerva skin. With that instead of Vector, the problem is gone. This also means that the link I gave above no longer shows a corrupted page.

Gsklayploy subscribed.Jan 29 2019, 5:28 PM

Jdlrobson moved this task from Needs triage to Tracking on the Vector (legacy skin) board.Jan 15 2020, 6:11 PM

Jdlrobson edited projects, added Vector (legacy skin) (Tracking); removed Vector (legacy skin).

Jdlrobson removed a project: Vector (legacy skin) (Tracking).

I'm not quite sure, but this could be done with T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook resolved?

yep. Please update to 1.35 if needed.

CookieWarning does not interact correctly with MobileFrontendClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

CookieWarning does not interact correctly with MobileFrontend
Closed, ResolvedPublic
Actions