Reference numbers wrong in Firefox when following a list
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

None

Authored By

	Schnark
	Jul 30 2019, 7:30 AM

Description

This is likely a bug in Firefox, but I'm reporting it here because it affects VE, and I can't find the root cause which would be necessary for a proper upstream bug report.

When editing an article where an ordinary list (e.g. list of external links) is followed by the list of references, the reference numbers are off by the count of the list before it. E.g. https://de.wikipedia.org/wiki/Vier_Vieren?veaction=edit has 2 external links, the references start with 3. Removing that list makes the references start with 11 instead (there is another list with 10 elements in the article).

I can only reproduce with Firefox, not with other browsers.

Details

	Subject	Repo	Branch	Lines +/-
	Fix broken reference list numbering in Firefox	mediawiki/extensions/Cite	REL1_34	+3 -1
	Fix broken reference list numbering in Firefox	mediawiki/extensions/Cite	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: rECITd18c0871a8df: Fix broken reference list numbering in Firefox

Event Timeline

Schnark created this task.Jul 30 2019, 7:30 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 30 2019, 7:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I was able to reduce it to a minimal example, and reported this upstream as https://bugzilla.mozilla.org/show_bug.cgi?id=1569886.

I can reproduce. Fascinating.

Screenshots for reference:

Firefox: (incorrect)

Opera: (correct)

If we needed to work around this, it seems that counter-reset: mw-ref-linkback works correctly when applied to ol.mw-references li:first-child instead of ol.mw-references. But presumably the same issue applies to other counters, and MediaWiki uses this in a bunch of places, so I'd rather see if a Firefox fix is coming soon first.

After reading https://drafts.csswg.org/css-lists-3/#list-item-counter: This might actually be the expected behavior (but I'm not going to encourage Firefox devs by making that comment on Bugzilla), and the correct workaround is counter-reset: mw-ref-linkback list-item.

And now I found https://bugzilla.mozilla.org/show_bug.cgi?id=1545746, which already is closed as invalid.

Pols12 subscribed.Nov 22 2019, 10:30 PM

Change 555905 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Fix broken reference list numbering in Firefox

https://gerrit.wikimedia.org/r/555905

gerritbot added a project: Patch-For-Review.Dec 9 2019, 9:13 AM

thiemowmde added projects: WMDE-QWERTY-Sprint-2019-11-20, Cite.Dec 9 2019, 9:14 AM

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-11-20 board.

Change 555905 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Fix broken reference list numbering in Firefox

https://gerrit.wikimedia.org/r/555905

thiemowmde mentioned this in rECITd18c0871a8df: Fix broken reference list numbering in Firefox.Dec 9 2019, 9:48 AM

awight moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2019-11-20 board.Dec 9 2019, 9:55 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2019, 10:10 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 9 2019, 11:00 AM

Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2019-12-11.Dec 11 2019, 9:13 AM

Tobi_WMDE_SW moved this task from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2019-12-11 board.Dec 11 2019, 9:14 AM

matmarex awarded a token.Dec 11 2019, 1:42 PM

Assigning random story points, please revise as needed.

awight changed the point value for this task from 8 to 5.Dec 19 2019, 10:45 AM

Izno moved this task from Unsorted backlog to Defect backlog on the Cite board.Dec 20 2019, 1:38 PM

This seems to be fixed and deployed. I just confirmed using FF and the example link above.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 7 2020, 12:30 PM

Change 567969 had a related patch set uploaded (by Edward Chernenko; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@REL1_34] Fix broken reference list numbering in Firefox

https://gerrit.wikimedia.org/r/567969

gerritbot added a project: Patch-For-Review.Jan 28 2020, 3:13 PM

Change 567969 merged by jenkins-bot:
[mediawiki/extensions/Cite@REL1_34] Fix broken reference list numbering in Firefox