Page MenuHomePhabricator

Map thumbnail does not show sometimes
Closed, ResolvedPublic

Description

Using Module:Mapframe with Template:Maplink on English Wikipedia

Sometimes the map thumbnail spontaneously stops showing. Yesterday I edited all sections of "Interstate 95" (read "Interstate 95 in Florida", in Georgia etc. - about 13 pages) to remove fixed lat/lot and zoom from template to allow for auto position and zoom (sample edit). I was logged in and the thumbnails showed for me. After few hours now the thumbnails do not show for the Maplink template on all the 13 pages. Switch to Template:MapframeForObjects at "Interstate 95 in Florida" (edit) again helps to show the thumbnail, question is for how long.

Besides the missing thumbnail the full screen map work properly also showing the feature.

I see 2 possible solutions to this problem:

  1. Fix the broken static thumbnails.
  2. Use tile server to load static map (= map without controls imitating the static thumbnail). The preview page now uses dynamic thumbnails (also adds + and - icons to it for zoom). Even with static thumbnail not showing the small map in preview renders ok - I guess it is fetched directly from tile server. Can we do the same in the saved article? I do not want the small map (thumbnail) to be dynamic as double click is then needed to open the full screen map (I prefer single click) but instead I mean to leave the small map static but under the hood to fetch its image directly from tile sever (on the fly).

This bug may have something in common with my other issue of thumbnail having problems to show when logged in (is opposite problem). Maybe as I was logged in while editing a "false" thumbnail was shown and maybe at the same time no thumbnail would show for anonymous user. I filed a bug for this issue but can not find the ticket now. Will add it later.

Event Timeline

I have new findings - after about an hour of the edit which switched the Florida page to Template:MapfactorForObjects now the thumbnail is stoppled showing again. The JS console shows following:

Failed to load resource: the server responded with a status of 400 ()
osm-intl,a,a,a,290x320.png:1

The full URL is following:
https://maps.wikimedia.org/img/osm-intl,a,a,a,290x320.png?lang=en&domain=en.wikipedia.org&title=Interstate+95+in+Florida&groups=_b656507c2d9e72952375f966e665463d9d2820a6

Calling that URL loads a page with this content:
"GroupId not available"

You can get the JS error on this page:
https://en.wikipedia.org/w/index.php?title=Interstate_95_in_Florida&oldid=909352572

Now the thumbnail in https://en.wikipedia.org/wiki/Interstate_95_in_Florida shows again. But in the other articles for other I95 section does not. This looks like on/off issue.

@Yurik Could you help fix this bug please?

I think this is mostly fixed now..
Unfortunately I also think these were multiple issues happening at once. Probably the php7 parser and broken Json inclusion. But also cached out of date static images and possibly the bug with mobile static images not working.

TheDJ claimed this task.

I'm resolving this, as most of this is fixed and separate tickets for any remaining issues exist or should be filed.