[Regression] Showing "No change in size" wrongly on Minerva diff pages and text enlarged
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Masumrezarock100
	Sep 15 2019, 12:21 AM

Description

Regression caused by: T231613 and T229440

After the recent update there have been a lot of changes can be seen in the diff pages. But it produced several bugs. Changes in size is being shown wrongly on diff pages. It is happening on every site where AMC mode is not enabled, it seems.
Update: This is affecting every users at the moment (including AMC users).

Steps to Reproduce:

Go to a mobile website.
Open a diff. (eg. https://commons.m.wikimedia.org/wiki/Special:MobileDiff/365754184 )

Actual Results:

It is shown that there is no change in size below the "Revision as of {{timestamp}}".
The text of the user info is enlarged.

Expected Results:

The "real" change are shown below the "Revision as of {{timestamp}}".

Screenshot:

The text fits the user info drawer.

QA steps

Test this on the beta cluster and check the 3 possible states have the correct icon and label:

Should show as bytes added:

https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397129

Zero bytes changed:

https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397299

Bytes removed:

https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397130

Confirm on https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397299 that text for user groups is capitalised, looks like this:

Similarly the date next to bytes changed should be the same size as the label alongside the "bytes changed" icon text.

QA Results

AC	Status	Details
1	✅	T232941#5509238
2	✅	T232941#5509238
3	✅	T232941#5509238
4	✅	T232941#5509238
5	✅	T232941#5509238

Details

	Subject	Repo	Branch	Lines +/-
	Follow up to diff pages text sizing and icon positioning	mediawiki/extensions/MobileFrontend	master	+18 -11
	Address Special:MobileDiff text and bytes changed regressions	mediawiki/extensions/MobileFrontend	master	+6 -1

Customize query in gerrit

Related Objects

Mentioned Here: T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency
T231613: Replace 24x24px SVGs in MF/Minerva

Event Timeline

Masumrezarock100 created this task.Sep 15 2019, 12:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2019, 12:21 AM

Reedy added projects: MobileFrontend, MinervaNeue.Sep 15 2019, 12:23 AM

Masumrezarock100 updated the task description. (Show Details)Sep 15 2019, 12:25 AM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptSep 15 2019, 12:25 AM

Masumrezarock100 updated the task description. (Show Details)Sep 15 2019, 12:27 AM

Masumrezarock100 renamed this task from Showing "No change in size" wrongly in Minerva diff page on Wikimedia Commons to Showing "No change in size" wrongly on Minerva diff pages on Wikimedia Commons.Sep 15 2019, 12:31 AM

Masumrezarock100 updated the task description. (Show Details)

Note:
This bug is not present on the diff pages on English Wikipedia. It is showing as usual. (eg, https://en.m.wikipedia.org/wiki/Special:MobileDiff/915730353 )

Screenshot

Masumrezarock100 updated the task description. (Show Details)Sep 15 2019, 12:48 AM

Masumrezarock100 added projects: Mobile, MediaWiki-Page-diffs.

Masumrezarock100 renamed this task from Showing "No change in size" wrongly on Minerva diff pages on Wikimedia Commons to Showing "No change in size" wrongly on Minerva diff pages on sites where AMC mode is not enabled.Sep 15 2019, 5:56 PM

Masumrezarock100 updated the task description. (Show Details)

Masumrezarock100 edited projects, added Web-Team-Backlog; removed MobileFrontend.

Masumrezarock100 moved this task from Backlog to Bugs on the MinervaNeue board.Sep 15 2019, 6:04 PM

Change 536710 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Address Special:MobileDiff text and bytes changed regressions

https://gerrit.wikimedia.org/r/536710

gerritbot added a project: Patch-For-Review.Sep 16 2019, 2:52 PM

Jdlrobson triaged this task as High priority.Sep 16 2019, 2:52 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.

Change 536710 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Address Special:MobileDiff text and bytes changed regressions

https://gerrit.wikimedia.org/r/536710

Jdlrobson moved this task from Needs Analysis to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 16 2019, 3:26 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 16 2019, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2019, 4:10 PM

In T232941#5493713, @Masumrezarock100 wrote:

Note:
This bug is not present on the diff pages on English Wikipedia. It is showing as usual. (eg, https://en.m.wikipedia.org/wiki/Special:MobileDiff/915730353 )

Screenshot

I am not sure why but I'm seeing the bug on that very diff.

IMG_20190916_172802_924.jpg (1×720 px, 123 KB)

And in fact, the bug now appears everywhere on whole English Wikipedia for me.

Masumrezarock100 renamed this task from Showing "No change in size" wrongly on Minerva diff pages on sites where AMC mode is not enabled to Showing "No change in size" wrongly on Minerva diff pages when AMC mode is not enabled.Sep 16 2019, 5:00 PM

Masumrezarock100 updated the task description. (Show Details)

@Ammarpad It seems this bug is appearing in every diff if AMC mode is not enabled (regardless of AMC's availability). I've updated the description. :) Jdlrobson has merged the patch, so you will see the change after the new Mediawiki version release.

Will add some QA instructions.

Jdlrobson updated the task description. (Show Details)Sep 16 2019, 5:10 PM

Masumrezarock100 updated the task description. (Show Details)Sep 16 2019, 5:20 PM

Thanks for flagging this @Masumrezarock100 !

This is affecting every users at the moment.

Masumrezarock100 updated the task description. (Show Details)Sep 16 2019, 6:25 PM

Jdlrobson moved this task from Needs QA to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 16 2019, 6:32 PM

Change 537177 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Follow up to diff pages

https://gerrit.wikimedia.org/r/537177

gerritbot added a project: Patch-For-Review.Sep 16 2019, 6:51 PM

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 16 2019, 6:57 PM

Jdlrobson updated the task description. (Show Details)Sep 16 2019, 7:06 PM

Jdlrobson updated the task description. (Show Details)

Change 537177 merged by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Follow up to diff pages text sizing and icon positioning

https://gerrit.wikimedia.org/r/537177

Please leave at least 30 minutes from now before QAing.

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2019, 10:11 PM

Jdlrobson renamed this task from [Regression] Showing "No change in size" wrongly on Minerva diff pages to [Regression] Showing "No change in size" wrongly on Minerva diff pages and text enlarged.Sep 17 2019, 1:06 AM

Jdlrobson merged a task: T233029: Reconsider enlargement of user info in mobile diff view.

Jdlrobson updated the task description. (Show Details)

Masumrezarock100 updated the task description. (Show Details)Sep 17 2019, 7:37 AM

ovasileva moved this task from Needs triage to Triaged on the Mobile board.Sep 17 2019, 3:29 PM

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

Test this on the beta cluster and check the 3 possible states have the correct icon and label:

✅ AC1: Should show as bytes added:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397129

Logged Off	Logged On - AMC Off	Logged On - AMC On

✅ AC2: Zero bytes changed:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397299

Logged Off	Logged On - AMC Off	Logged On - AMC On

✅ AC3: Bytes removed:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397130

Logged Off	Logged On - AMC Off	Logged On - AMC On

✅ AC4: Confirm on https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/397299 that text for user groups is capitalized, looks like this:

Logged Off	Logged On - AMC Off	Logged On - AMC On

✅ AC5: Similarly the date next to bytes changed should be the same size as the label alongside the "bytes changed" icon text.

Logged Off	Logged On - AMC Off	Logged On - AMC On

Edtadros updated the task description. (Show Details)Sep 20 2019, 1:28 PM

Looks good.

	F30408002: T232941-5c.png
	Sep 20 2019, 1:27 PM

	F30407968: T232941-1b.png
	Sep 20 2019, 1:27 PM

	F30407878: T232941-1.png
	Sep 20 2019, 1:27 PM

	F30408000: T232941-4c.png
	Sep 20 2019, 1:27 PM

[Regression] Showing "No change in size" wrongly on Minerva diff pages and text enlargedClosed, ResolvedPublicBUG REPORTActions

Description

Steps to Reproduce:

Actual Results:

Expected Results:

QA steps

QA Results

Details

Related Objects

Event Timeline

Test Result

QA steps

[Regression] Showing "No change in size" wrongly on Minerva diff pages and text enlarged
Closed, ResolvedPublicBUG REPORT
Actions