Page MenuHomePhabricator
Create Task
Maniphest T253402

Blank lines in visual mode not stripped
Closed, ResolvedPublic
Actions

Description

Reported here: https://w.wiki/RaC

We strip blank lines in source mode.

If you enter:
Foo
<blankline>
Bar

in visual mode, we should serialize to

::Foo
::Bar

not

::Foo
::
::Bar

Details

SubjectRepoBranchLines +/-
Remove empty lines in visual mode toomediawiki/extensions/DiscussionToolsmaster+13 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.May 22 2020, 5:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 22 2020, 5:18 PM
gerritbot added a comment.May 22 2020, 5:19 PM

Change 598084 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Remove empty lines in visual mode too

https://gerrit.wikimedia.org/r/598084

gerritbot added a project: Patch-For-Review.May 22 2020, 5:19 PM
Esanders moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.May 22 2020, 5:19 PM
Dvorapa subscribed.May 22 2020, 7:06 PM
gerritbot added a comment.May 25 2020, 5:15 PM

Change 598084 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Remove empty lines in visual mode too

https://gerrit.wikimedia.org/r/598084

matmarex edited projects, added Editing QA; removed Patch-For-Review.May 25 2020, 5:18 PM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 25 2020, 6:00 PM
Ryasmeen edited projects, added Verified; removed Editing QA.May 28 2020, 11:46 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.
Dvorapa mentioned this in T253584: Strikethrough in Reply tool adds <s> tags with href attribute.May 29 2020, 1:54 PM
ppelberg closed this task as Resolved.Jun 1 2020, 1:31 AM
geraki mentioned this in T265564: Allow inserting a new line.Apr 1 2021, 2:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL