Page MenuHomePhabricator

Focus order is illogical in the insert link pane after Cancel button
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  • Go to a page
  • Navigate to edit source and hit enter
  • Navigate till "Insert Link" and hit enter
  • Navigate to "Cancel" using keyboard and hit enter

Actual Results:

  • Focus order illogical after hitting cancel

Expected Results:

  • Focus should go to link button

Event Timeline

Change 598541 had a related patch set uploaded (by Bkudiess-msft; owner: Bkudiess-msft):
[mediawiki/extensions/WikiEditor@master] Restores focus after dialog closes

https://gerrit.wikimedia.org/r/598541

Change 598541 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Restores focus after dialog closes

https://gerrit.wikimedia.org/r/598541

@Bkudiess-msft: Hi, the patch in Gerrit has been merged. Can this task be resolved (via Add Action...Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance! :)