WVUI Docker improvements
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	• nnikkhoui
	Sep 24 2020, 7:40 PM

Description

The Docker setup for WVUI has room for some improvements:

The release scripts to easily release a new version of WVUI on npm. Those scripts as of now can only be run outside the container, but ideally should be run inside Docker with a command like: docker-compose run --rm node ./bin/release-dev. Another option: move the prepublishOnly NPM script out of package.json and into the shell scripts, and call docker-compose run --rm node <command> from the shell scripts as needed.

Based on your host OS, the Dockerfile will behave differently in assigning Docker generated files a user and group. The docker-compose commands also require build arguments (docker-compose run --rm --build-args UID) to get this to work properly. Look into a cleaner way of doing this, to be consistent across OS's and/or remove the number of CLI args required.

Details

	Subject	Repo	Branch	Lines +/-
	Separate node_modules between host and docker	wvui	master	+29 -6
	Publish new wvui development versions through Docker container	wvui	master	+60 -12

Customize query in gerrit

Related Objects

Mentioned In: rWVUIb7559caba59a: Publish new wvui development versions through Docker container
rWVUI694b257490dd: Publish new wvui development versions through Docker container
T254837: Create a Docker configuration for building WVUI for Vue.js search

Event Timeline

• nnikkhoui created this task.Sep 24 2020, 7:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2020, 7:40 PM

• nnikkhoui renamed this task from Execute rolling release scripts inside Docker container to WVUI Docker improvements .Sep 25 2020, 4:29 PM

• nnikkhoui updated the task description. (Show Details)

• nnikkhoui added a subscriber: • Niedzielski.

• Niedzielski mentioned this in T254837: Create a Docker configuration for building WVUI for Vue.js search.Sep 25 2020, 5:23 PM

• Niedzielski updated the task description. (Show Details)Sep 28 2020, 2:38 PM

• Niedzielski moved this task from Backlog to Ready on the Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)) board.Sep 28 2020, 6:28 PM

Change 640245 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[wvui@master] Experimental: Publish new wvui versions through Docker container

https://gerrit.wikimedia.org/r/640245

gerritbot added a project: Patch-For-Review.Nov 9 2020, 8:52 PM

Volker_E moved this task from Backlog to Next-up on the WVUI board.Nov 20 2020, 7:09 PM

Change 640245 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[wvui@master] Experimental: Publish new wvui versions through Docker container

https://gerrit.wikimedia.org/r/640245

Running into an issue to document:

Node modules are compiled differently when npm install-ed on the host machine (for me a Mac) vs the docker Debian image. This causes a problem because the pre-commit hooks that fire on the host would need Mac OS-compiled node modules, but the release scripts that run inside the docker image would need a set of Debian-compiled node modules. This makes it so we can't use the same node_modules directory when doing a local commit to gerrit and running the release scripts inside the docker container.

The easiest option I see is to require running npm ci before committing any code to gerrit so the whole node_modules directory is rebuilt. A little annoying, but this situation shouldnt come up too often.

• nnikkhoui mentioned this in rWVUI694b257490dd: Publish new wvui development versions through Docker container.Dec 4 2020, 12:47 AM

Change 649758 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[wvui@master] WIP: Separate node_modules between host and docker

https://gerrit.wikimedia.org/r/649758

Change 640245 merged by jenkins-bot:

[wvui@master] Publish new wvui development versions through Docker container

https://gerrit.wikimedia.org/r/640245

jenkins-bot mentioned this in rWVUIb7559caba59a: Publish new wvui development versions through Docker container.Apr 28 2021, 3:15 PM

Volker_E moved this task from Next-up to Doing on the WVUI board.Jul 31 2021, 1:36 AM

• STH moved this task from Vue.js Search Experience (Vector modern) to Patches for Code Review (let's try to clear this out) on the Design-Systems-team-20200324-20220422 board.Mar 23 2022, 8:05 PM

• STH edited projects, added Design-Systems-team-20200324-20220422; removed Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)).

• STH edited projects, added Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)); removed Design-Systems-team-20200324-20220422.Mar 23 2022, 8:09 PM

• STH moved this task from Ready to Needs Review on the Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)) board.

Change 649758 abandoned by Nikki Nikkhoui:

[wvui@master] Separate node_modules between host and docker